* [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
@ 2014-08-22 7:12 Lukasz Majewski
2014-08-22 8:10 ` Robert Baldyga
2014-08-28 19:49 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 5+ messages in thread
From: Lukasz Majewski @ 2014-08-22 7:12 UTC (permalink / raw)
To: u-boot
The commit (SHA1: 8fc171318e352) reintroduced correct values for vendor and
product IDs required for UMS gadget to work properly either at Windows or
Linux.
This data was missing for GONI target, so this commit corrects this mistake.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
include/configs/s5p_goni.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
index 6e795bf..a51215d 100644
--- a/include/configs/s5p_goni.h
+++ b/include/configs/s5p_goni.h
@@ -91,6 +91,8 @@
#define CONFIG_G_DNL_PRODUCT_NUM 0x6601
#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
+#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
+#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
#define CONFIG_G_DNL_MANUFACTURER "Samsung"
/* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
2014-08-22 7:12 [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget Lukasz Majewski
@ 2014-08-22 8:10 ` Robert Baldyga
2014-08-25 7:26 ` Lukasz Majewski
2014-08-28 19:49 ` [U-Boot] " Tom Rini
1 sibling, 1 reply; 5+ messages in thread
From: Robert Baldyga @ 2014-08-22 8:10 UTC (permalink / raw)
To: u-boot
On 08/22/2014 09:12 AM, Lukasz Majewski wrote:
> The commit (SHA1: 8fc171318e352) reintroduced correct values for vendor and
> product IDs required for UMS gadget to work properly either at Windows or
> Linux.
>
> This data was missing for GONI target, so this commit corrects this mistake.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
> include/configs/s5p_goni.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> index 6e795bf..a51215d 100644
> --- a/include/configs/s5p_goni.h
> +++ b/include/configs/s5p_goni.h
> @@ -91,6 +91,8 @@
> #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
> #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
> #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
> +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
> +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
> #define CONFIG_G_DNL_MANUFACTURER "Samsung"
>
> /* Actual modem binary size is 16MiB. Add 2MiB for bad block handling */
>
Acked-by: Robert Baldyga <r.baldyga@samsung.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
2014-08-22 8:10 ` Robert Baldyga
@ 2014-08-25 7:26 ` Lukasz Majewski
2014-08-28 11:33 ` Minkyu Kang
0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2014-08-25 7:26 UTC (permalink / raw)
To: u-boot
Hi Tom,
> On 08/22/2014 09:12 AM, Lukasz Majewski wrote:
> > The commit (SHA1: 8fc171318e352) reintroduced correct values for
> > vendor and product IDs required for UMS gadget to work properly
> > either at Windows or Linux.
> >
> > This data was missing for GONI target, so this commit corrects this
> > mistake.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > ---
> > include/configs/s5p_goni.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> > index 6e795bf..a51215d 100644
> > --- a/include/configs/s5p_goni.h
> > +++ b/include/configs/s5p_goni.h
> > @@ -91,6 +91,8 @@
> > #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
> > #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
> > #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
> > +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
> > +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
> > #define CONFIG_G_DNL_MANUFACTURER "Samsung"
> >
> > /* Actual modem binary size is 16MiB. Add 2MiB for bad block
> > handling */
> >
>
> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
Tom, since Robert - the maintainer of the GONI board has acked the
patch and the patch itself adds only missing defines, could you pull
this patch to mainline ASAP?
It fixes build breaks caused by the GONI board :-)
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
2014-08-25 7:26 ` Lukasz Majewski
@ 2014-08-28 11:33 ` Minkyu Kang
0 siblings, 0 replies; 5+ messages in thread
From: Minkyu Kang @ 2014-08-28 11:33 UTC (permalink / raw)
To: u-boot
On 25/08/14 16:26, Lukasz Majewski wrote:
> Hi Tom,
>
>> On 08/22/2014 09:12 AM, Lukasz Majewski wrote:
>>> The commit (SHA1: 8fc171318e352) reintroduced correct values for
>>> vendor and product IDs required for UMS gadget to work properly
>>> either at Windows or Linux.
>>>
>>> This data was missing for GONI target, so this commit corrects this
>>> mistake.
>>>
>>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
>>> ---
>>> include/configs/s5p_goni.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
>>> index 6e795bf..a51215d 100644
>>> --- a/include/configs/s5p_goni.h
>>> +++ b/include/configs/s5p_goni.h
>>> @@ -91,6 +91,8 @@
>>> #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
>>> #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
>>> #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
>>> +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
>>> +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
>>> #define CONFIG_G_DNL_MANUFACTURER "Samsung"
>>>
>>> /* Actual modem binary size is 16MiB. Add 2MiB for bad block
>>> handling */
>>>
>>
>> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
>
> Tom, since Robert - the maintainer of the GONI board has acked the
> patch and the patch itself adds only missing defines, could you pull
> this patch to mainline ASAP?
>
> It fixes build breaks caused by the GONI board :-)
>
If Tom will merge it to mainline then,
Acked-by: Minkyu Kang <mk7.kang@samsung.com>
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget
2014-08-22 7:12 [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget Lukasz Majewski
2014-08-22 8:10 ` Robert Baldyga
@ 2014-08-28 19:49 ` Tom Rini
1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2014-08-28 19:49 UTC (permalink / raw)
To: u-boot
On Fri, Aug 22, 2014 at 09:12:58AM +0200, ?ukasz Majewski wrote:
> The commit (SHA1: 8fc171318e352) reintroduced correct values for vendor and
> product IDs required for UMS gadget to work properly either at Windows or
> Linux.
>
> This data was missing for GONI target, so this commit corrects this mistake.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
> Acked-by: Minkyu Kang <mk7.kang@samsung.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140828/9ab5e64d/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-28 19:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 7:12 [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget Lukasz Majewski
2014-08-22 8:10 ` Robert Baldyga
2014-08-25 7:26 ` Lukasz Majewski
2014-08-28 11:33 ` Minkyu Kang
2014-08-28 19:49 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox