From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Fri, 22 Aug 2014 11:33:39 -0600
Subject: [U-Boot] [PATCH 15/23] pci: tegra: Add Tegra PCIe driver
In-Reply-To: <53F4F136.7010708@wwwdotorg.org>
References: <1408346196-30419-1-git-send-email-thierry.reding@gmail.com>
	<1408346196-30419-16-git-send-email-thierry.reding@gmail.com>
	<53F4F136.7010708@wwwdotorg.org>
Message-ID: <53F77EF3.6090903@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/20/2014 01:04 PM, Stephen Warren wrote:
> On 08/18/2014 01:16 AM, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Add support for the PCIe controller found on some generations of Tegra.
>> Tegra20 has 2 root ports with a total of 4 lanes, Tegra30 has 3 root
>> ports with a total of 6 lanes and Tegra124 has 2 root ports with a total
>> of 5 lanes.
>
>> diff --git a/drivers/pci/pci_tegra.c b/drivers/pci/pci_tegra.c

>> +static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port)
>> +{
>> +    unsigned int retries = 3;
>> +    unsigned long value;
>> +
>> +    value = rp_readl(port, RP_PRIV_MISC);
>> +    value &= ~RP_PRIV_MISC_PRSNT_MAP_EP_ABSNT;
>> +    value |= RP_PRIV_MISC_PRSNT_MAP_EP_PRSNT;
>> +    rp_writel(port, value, RP_PRIV_MISC);
>> +
>> +    do {
>> +        unsigned int timeout = 200;
>> +
>> +        do {
>> +            value = rp_readl(port, RP_VEND_XP);
>> +            if (value & RP_VEND_XP_DL_UP)
>> +                break;
>
> On my board, this almost never succeeds for Jetson TK1's built-in NIC,
> although it works fine for the mini-PCIe slot. On the other two boards I
> borrowed, this succeeds almost always. I'd prefer if we could get to the
> bottom of this before we actually apply this, although the bug is
> proving quite perplexing. The mainline kernel PCIe patches have the same
> issue.

I tracked the issue down to some missing pinmux configuration for the 
PCIe reset lane. With that in place, both U-Boot and the mainline Linux 
kernel PCIe support appear to work reliably. I'll work on patches to 
resolve that. So, I think we can go ahead and merge these patches 
without issue ASAP, as soon as any review comments are addressed.