public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R
Date: Fri, 22 Aug 2014 12:06:03 -0600	[thread overview]
Message-ID: <53F7868B.8040108@wwwdotorg.org> (raw)
In-Reply-To: <1408716505-9013-1-git-send-email-l.majewski@samsung.com>

On 08/22/2014 08:08 AM, Lukasz Majewski wrote:
> This commit provides distinction between DFU device detach and reset.
> The -R behavior is preserved with proper handling of the dfu-util's -e
> switch, which detach the DFU device.
>
> By running dfu-util -e; one can force device to finish the execution of
> dfu command on target and execute some other scripted commands.

This sounds extremely useful; I wonder if UMS could have the same feature?

> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c

> +static bool dfu_reset;

Can't this be a local variable inside the do_dfu() function?

Aside from that,
Reviewed-by: Stephen Warren <swarren@nvidia.com>

  parent reply	other threads:[~2014-08-22 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 14:08 [U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R Lukasz Majewski
2014-08-22 14:08 ` [U-Boot] [PATCH 2/2] udc: dfu: s3c_udc: Provide function to check if USB reset was asserted Lukasz Majewski
2014-08-22 18:06   ` Stephen Warren
2014-08-22 19:57     ` Lukasz Majewski
2014-08-22 18:06 ` Stephen Warren [this message]
2014-08-22 19:59   ` [U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R Lukasz Majewski
2014-08-25  9:07 ` [U-Boot] [PATCH v2 " Lukasz Majewski
2014-08-25  9:07   ` [U-Boot] [PATCH v2 2/2] udc: dfu: s3c_udc: Provide function to check if USB reset was asserted Lukasz Majewski
2014-08-25 20:01 ` [U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R Stephen Warren
2014-09-01  7:27   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F7868B.8040108@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox