From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 22 Aug 2014 12:06:03 -0600 Subject: [U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R In-Reply-To: <1408716505-9013-1-git-send-email-l.majewski@samsung.com> References: <1408716505-9013-1-git-send-email-l.majewski@samsung.com> Message-ID: <53F7868B.8040108@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/22/2014 08:08 AM, Lukasz Majewski wrote: > This commit provides distinction between DFU device detach and reset. > The -R behavior is preserved with proper handling of the dfu-util's -e > switch, which detach the DFU device. > > By running dfu-util -e; one can force device to finish the execution of > dfu command on target and execute some other scripted commands. This sounds extremely useful; I wonder if UMS could have the same feature? > diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c > +static bool dfu_reset; Can't this be a local variable inside the do_dfu() function? Aside from that, Reviewed-by: Stephen Warren