public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: tegra: initial support for apalis t30
Date: Fri, 22 Aug 2014 13:31:29 -0600	[thread overview]
Message-ID: <53F79A91.2060702@wwwdotorg.org> (raw)
In-Reply-To: <1f0fc67d6f08de8deba78762088fa61e2a195152.1408687805.git.marcel@ziswiler.com>

On 08/22/2014 01:35 AM, Marcel Ziswiler wrote:
> This patch adds board support for the Toradex Apalis T30 a computer on
> module which can be used on different carrier boards.
>
> For the sake of ease of use we do not distinguish between different
> carrier boards for now as the base module features are deemed
> sufficient enough for regular booting.
>
> The following functionality is working so far:
> - eMMC boot and environment storage
> - Gigabit Ethernet (once Thierry's PCIe as well as Marek's i210 patches
>    hit mainline)
> - MMC/SD cards (both 8-bit as well as 4-bit slot)
> - USB client/host (dual role port as client e.g. for DFU/UMS, other two
>    ports as host)

Looks fine at a quick glance, just one nit below, otherwise,
Acked-by: Stephen Warren <swarren@nvidia.com>

> diff --git a/configs/apalis_t30_defconfig b/configs/apalis_t30_defconfig

> +/* USB networking support */
> +#define CONFIG_USB_HOST_ETHER
> +#define CONFIG_USB_ETHER_ASIX
> +
> +#define CONFIG_USE_ARCH_MEMCPY

That last option isn't set on other Tegra boards; what's it for?

  reply	other threads:[~2014-08-22 19:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4e5681daf84a08d160751c3da392f654e2b440ef.1408687805.git.marcel@ziswiler.com>
2014-08-22  7:35 ` [U-Boot] [PATCH v2] arm: tegra: initial support for apalis t30 Marcel Ziswiler
2014-08-22 19:31   ` Stephen Warren [this message]
2014-08-24 21:18     ` Marcel Ziswiler
2014-08-25  9:24       ` Thierry Reding
2014-08-25 16:09       ` Stephen Warren
2014-08-26  9:45         ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F79A91.2060702@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox