From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mvebu_mmc: Driver addition
Date: Mon, 25 Aug 2014 12:58:21 +0200 [thread overview]
Message-ID: <53FB16CD.4050107@denx.de> (raw)
In-Reply-To: <CAAwVp3s7OaZNtTDHD56OnreD6p+Mhp-kdf0DHp-8J5Bf6a3K-g@mail.gmail.com>
On 25.08.2014 12:53, Mario Schuknecht wrote:
> +/*
> + * Set window register.
> + */
> +static void mvebu_window_setup(void)
> +{
> + int i;
> +
> + for (i = 0; i < 4; i++) {
> + mvebu_mmc_write(WINDOW_CTRL(i)__, 0);
> + mvebu_mmc_write(WINDOW_BASE(i)__, 0);
> + }
>
>
> Spaces instead of tabs for indentation. Please fix globally
> (checkpatch clean)
>
> A question. What is meant by "Spaces instead of tabs for indentation"?
> In the whole file (and other files) tabs are used for indentation.
No. I meant, use only tabs for indentation. In the line above you have
used spaces instead of tabs. Checkpatch should warn about those issues.
Its recommended to run it before sending patches to the list.
Thanks,
Stefan
prev parent reply other threads:[~2014-08-25 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 19:31 [U-Boot] [PATCH] mvebu_mmc: Driver addition Mario Schuknecht
2014-08-25 9:55 ` Stefan Roese
2014-08-25 10:53 ` Mario Schuknecht
2014-08-25 10:58 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB16CD.4050107@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox