From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Thu, 28 Aug 2014 20:33:14 +0900 Subject: [U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget In-Reply-To: <20140825092618.3bc93d38@amdc2363> References: <1408691578-21816-1-git-send-email-l.majewski@samsung.com> <53F6FAE7.40406@samsung.com> <20140825092618.3bc93d38@amdc2363> Message-ID: <53FF137A.9080100@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 25/08/14 16:26, Lukasz Majewski wrote: > Hi Tom, > >> On 08/22/2014 09:12 AM, Lukasz Majewski wrote: >>> The commit (SHA1: 8fc171318e352) reintroduced correct values for >>> vendor and product IDs required for UMS gadget to work properly >>> either at Windows or Linux. >>> >>> This data was missing for GONI target, so this commit corrects this >>> mistake. >>> >>> Signed-off-by: Lukasz Majewski >>> --- >>> include/configs/s5p_goni.h | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h >>> index 6e795bf..a51215d 100644 >>> --- a/include/configs/s5p_goni.h >>> +++ b/include/configs/s5p_goni.h >>> @@ -91,6 +91,8 @@ >>> #define CONFIG_G_DNL_PRODUCT_NUM 0x6601 >>> #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM >>> #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D >>> +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525 >>> +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5 >>> #define CONFIG_G_DNL_MANUFACTURER "Samsung" >>> >>> /* Actual modem binary size is 16MiB. Add 2MiB for bad block >>> handling */ >>> >> >> Acked-by: Robert Baldyga > > Tom, since Robert - the maintainer of the GONI board has acked the > patch and the patch itself adds only missing defines, could you pull > this patch to mainline ASAP? > > It fixes build breaks caused by the GONI board :-) > If Tom will merge it to mainline then, Acked-by: Minkyu Kang Thanks, Minkyu Kang.