From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kbuild: force to define __UBOOT__ in all the C sources
Date: Mon, 01 Sep 2014 10:51:17 +0200 [thread overview]
Message-ID: <54043385.701@denx.de> (raw)
In-Reply-To: <201408311048.07463.marex@denx.de>
Hello Masahiro,
Am 31.08.2014 10:48, schrieb Marek Vasut:
> On Sunday, August 31, 2014 at 08:16:53 AM, Masahiro Yamada wrote:
>> U-Boot has imported various source files from other projects,
>> mostly Linux.
>>
>> Something like
>>
>> #ifdef __UBOOT__
>> [ modification for U-Boot ]
>> #else
>> [ original code ]
>> #endif
>>
>> is an often used strategy for clarification of adjusted parts,
>> that is, easier re-sync in future.
>>
>> Instead of defining __UBOOT__ in each source file,
>> passing it from the top Makefile would be easier.
>>
>> Signed-off-by: Masahiro Yamada<yamada.m@jp.panasonic.com>
>> ---
>
> Nice idea,
>
> Acked-by: Marek Vasut<marex@denx.de>
Acked-by: Heiko Schocher <hs@denx.de>
Maybe we should add an entry in README too?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2014-09-01 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 6:16 [U-Boot] [PATCH] kbuild: force to define __UBOOT__ in all the C sources Masahiro Yamada
2014-08-31 8:48 ` Marek Vasut
2014-09-01 8:51 ` Heiko Schocher [this message]
2014-09-17 0:44 ` [U-Boot] " Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2014-08-31 7:23 [U-Boot] [PATCH] " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54043385.701@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox