From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/2] blackfin: convert blackfin board_f and board_r to use generic board init functions
Date: Mon, 01 Sep 2014 13:01:38 +0200 [thread overview]
Message-ID: <54045212.4030907@monstr.eu> (raw)
In-Reply-To: <CAJxxZ0NvyJFb97tQQreST_-9Hs8vyb1TuXWsH4c5BuGEBQ49oQ@mail.gmail.com>
On 09/01/2014 04:52 AM, Sonic Zhang wrote:
> Hi Michael,
>
> On Fri, Aug 29, 2014 at 8:20 PM, Michal Simek <monstr@monstr.eu> wrote:
>> Hi Sonic
>>
>> On 08/07/2014 09:08 AM, Sonic Zhang wrote:
>>> From: Sonic Zhang <sonic.zhang@analog.com>
>>>
>>> - move blackfin specific cpu init code from blackfin board.c to cpu.c
>>> - remove blackfin specific board init code and invoke generic board_f fron cpu init entry
>>> - rename section name bss_vma to bss_start in order to match the generic board init code
>>> - add a fake relocate_code function to set up the new stack only
>>
>> I would like get more information about this change.
>> I have spent some time on Microblaze to move to generic board
>> and I need to use sort of the same approach.
>> I will play with full reloc but as I see there will be a lot of additional
>> code generated which increase u-boot footprint and brings nothing.
>>
>> That's why I would like to know why you have decided to use fake relocate_code
>> function and what setup you are using before and "after" relocation (location of stack, gd, malloc
>> areas, etc).
>
> The Blackfin u-boot start code has already done the relocation before
> the generic board_init_f() is invoked. But, the new stack pointer can
> not be set until all functions in init_sequence_f[] are done. So, the
> last function in init_sequence_f[] relocate_code() is used to update
> the stack point and jump to the generic board_init_f(). Blackfin
> architecture defines global static gd and bd data and set the init
> stack point to (CONFIG_SYS_MALLOC_BASE - 4).
Ah ok.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140901/f4366f3d/attachment.pgp>
prev parent reply other threads:[~2014-09-01 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 7:08 [U-Boot] [PATCH v4 1/2] blackfin: convert blackfin board_f and board_r to use generic board init functions Sonic Zhang
2014-08-07 7:08 ` [U-Boot] [PATCH v4 2/2] support blackfin board initialization in generic board_f Sonic Zhang
2014-08-08 16:50 ` Tom Rini
2014-08-29 12:20 ` [U-Boot] [PATCH v4 1/2] blackfin: convert blackfin board_f and board_r to use generic board init functions Michal Simek
2014-09-01 2:52 ` Sonic Zhang
2014-09-01 11:01 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54045212.4030907@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox