From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nitin Garg Date: Tue, 2 Sep 2014 20:36:38 -0500 Subject: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images In-Reply-To: References: <1409516179-32553-1-git-send-email-nitin.garg@freescale.com> <1409516179-32553-2-git-send-email-nitin.garg@freescale.com> Message-ID: <540670A6.8020105@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/31/2014 08:09 PM, Otavio Salvador wrote: > Hello Nitin, > > On Sun, Aug 31, 2014 at 5:16 PM, wrote: >> From: Nitin Garg >> >> Add hab_auth_img u-boot command which can be used for HAB authentication >> of images. >> >> Signed-off-by: Nitin Garg > > As the other patch I commented, this commit log also needs some rework > to comply to the guidelines. I would also welcome a more detailed > description about what this adds on top of previous HAB code. > I will improve the commit log and add detailed description. > ... >> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h >> index 306d699..2bbb86e 100644 >> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h >> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h > ... >> @@ -11,7 +13,7 @@ >> #include >> #include "../arch-imx/cpu.h" >> >> -#define soc_rev() (get_cpu_rev() & 0xFF) >> +#define soc_rev() ((int)(get_cpu_rev() & 0xFF)) > > This seems unrelated change, isn't it? > Since get_cpu_rev returns unsigned int, this was causing a mix of unsigned int and int across binary operators. e.g: if(soc_rev() >= CHIP_REV_1_5)