From: Nitin Garg <nitin.garg@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images
Date: Tue, 2 Sep 2014 20:47:44 -0500 [thread overview]
Message-ID: <54067340.8010906@freescale.com> (raw)
In-Reply-To: <CAP9ODKrC-wR6vF969dPv=PV1NxMGzkKKcC=fPr=yqMp5+cwpHg@mail.gmail.com>
On 09/02/2014 08:41 PM, Otavio Salvador wrote:
> Hello Nitin,
>
> On Tue, Sep 2, 2014 at 10:36 PM, Nitin Garg <nitin.garg@freescale.com> wrote:
>> On 08/31/2014 08:09 PM, Otavio Salvador wrote:
>>>> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
>>>> index 306d699..2bbb86e 100644
>>>> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
>>>> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
>>> ...
>>>> @@ -11,7 +13,7 @@
>>>> #include <asm/imx-common/regs-common.h>
>>>> #include "../arch-imx/cpu.h"
>>>>
>>>> -#define soc_rev() (get_cpu_rev() & 0xFF)
>>>> +#define soc_rev() ((int)(get_cpu_rev() & 0xFF))
>>>
>>> This seems unrelated change, isn't it?
>>>
>> Since get_cpu_rev returns unsigned int, this was causing
>> a mix of unsigned int and int across binary operators.
>>
>> e.g:
>> if(soc_rev() >= CHIP_REV_1_5)
>
> In this case, please split this change.
>
> Shouldn't this to be fixed in the get_cpu_rev?
>
> Cheers,
>
But get_cpu_rev is correct, it returns unsigned int.
The problem happens in hab code where there are
comparisons between int and unsigned int, hence
I think it should not be split. Pls advice.
next prev parent reply other threads:[~2014-09-03 1:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 20:16 [U-Boot] [PATCH] i.MX6 High Assurance Boot (HAB) support nitin.garg at freescale.com
2014-08-31 20:16 ` [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images nitin.garg at freescale.com
2014-09-01 1:09 ` Otavio Salvador
2014-09-03 1:36 ` Nitin Garg
2014-09-03 1:41 ` Otavio Salvador
2014-09-03 1:47 ` Nitin Garg [this message]
2014-09-03 1:49 ` Otavio Salvador
2014-09-03 1:52 ` Fabio Estevam
2014-09-03 1:55 ` Nitin Garg
2014-09-03 2:54 ` Otavio Salvador
2014-09-04 0:10 ` Fabio Estevam
2014-09-04 1:10 ` Nitin Garg
2014-09-01 5:29 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54067340.8010906@freescale.com \
--to=nitin.garg@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox