From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nitin Garg <nitin.garg@freescale.com>
Date: Tue, 2 Sep 2014 20:47:44 -0500
Subject: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB)
 authentication of images
In-Reply-To: <CAP9ODKrC-wR6vF969dPv=PV1NxMGzkKKcC=fPr=yqMp5+cwpHg@mail.gmail.com>
References: <1409516179-32553-1-git-send-email-nitin.garg@freescale.com>	<1409516179-32553-2-git-send-email-nitin.garg@freescale.com>	<CAP9ODKrBO3rEs=MX8KvyZWrrZGdaj+oXBkYVGCj7y0Sb+MSymQ@mail.gmail.com>	<540670A6.8020105@freescale.com>
	<CAP9ODKrC-wR6vF969dPv=PV1NxMGzkKKcC=fPr=yqMp5+cwpHg@mail.gmail.com>
Message-ID: <54067340.8010906@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/02/2014 08:41 PM, Otavio Salvador wrote:
> Hello Nitin,
> 
> On Tue, Sep 2, 2014 at 10:36 PM, Nitin Garg <nitin.garg@freescale.com> wrote:
>> On 08/31/2014 08:09 PM, Otavio Salvador wrote:
>>>> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
>>>> index 306d699..2bbb86e 100644
>>>> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
>>>> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
>>> ...
>>>> @@ -11,7 +13,7 @@
>>>>  #include <asm/imx-common/regs-common.h>
>>>>  #include "../arch-imx/cpu.h"
>>>>
>>>> -#define soc_rev() (get_cpu_rev() & 0xFF)
>>>> +#define soc_rev() ((int)(get_cpu_rev() & 0xFF))
>>>
>>> This seems unrelated change, isn't it?
>>>
>> Since get_cpu_rev returns unsigned int, this was causing
>> a mix of unsigned int and int across binary operators.
>>
>> e.g:
>> if(soc_rev() >= CHIP_REV_1_5)
> 
> In this case, please split this change.
> 
> Shouldn't this to be fixed in the get_cpu_rev?
> 
> Cheers,
> 
But get_cpu_rev is correct, it returns unsigned int.
The problem happens in hab code where there are 
comparisons between int and unsigned int, hence 
I think it should not be split. Pls advice.