From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter A. Bigot <pab@pabigot.com>
Date: Wed, 03 Sep 2014 12:30:31 -0500
Subject: [U-Boot] [PATCH v2] env_mmc: correct fini partition to match
	init partition
In-Reply-To: <5407473E.2000909@wwwdotorg.org>
References: <1409700683-25393-2-git-send-email-pab@pabigot.com>
	<1409761938-27902-1-git-send-email-pab@pabigot.com>
	<5407473E.2000909@wwwdotorg.org>
Message-ID: <54075037.1030601@pabigot.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/03/2014 11:52 AM, Stephen Warren wrote:
> On 09/03/2014 10:32 AM, Peter A. Bigot wrote:
>> The code to set the MMC partition uses an weak function to obtain the
>> correct partition number.  Use that instead of the compile-time default
>> when deciding whether it needs to switch back.
>
> Yes, this clearly fixes a bug.
>
> Can you also please add a Fixes: tag that refers to the commit which 
> introduced the problem (i.e. which updated mmc_set_env_part() to call 
> mmc_get_env_part(), but forgot to update fini_mmc_for_env() to match.

Done.

If this tag is important enough to ask people to add it and resubmit 
their patches with no other changes, it should probably be described at 
http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags and 
suggested in the section on general patch submission rules, so the poor 
contributor might have a chance of being able to avoid the rework.

Peter