* [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found
@ 2014-09-04 13:16 Masahiro Yamada
2014-09-04 15:01 ` Stephen Warren
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Masahiro Yamada @ 2014-09-04 13:16 UTC (permalink / raw)
To: u-boot
When a non-existing defconfig is specified,
display an easy-to-understand message
(fake the error message on Linux Kernel):
$ make foo_defconfig
***
*** Can't find default configuration "confis/foo_defconfig"!
***
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
Changes in v2:
- Echo the error message to stderr
scripts/multiconfig.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/multiconfig.sh b/scripts/multiconfig.sh
index a579042..49fcfad 100644
--- a/scripts/multiconfig.sh
+++ b/scripts/multiconfig.sh
@@ -118,6 +118,13 @@ do_board_defconfig () {
defconfig_path=$srctree/configs/$1
tmp_defconfig_path=configs/.tmp_defconfig
+ if [ ! -r $defconfig_path ]; then
+ echo >&2 "***"
+ echo >&2 "*** Can't find default configuration \"confis/$1\"!"
+ echo >&2 "***"
+ exit 1
+ fi
+
mkdir -p arch configs
# defconfig for Normal:
# pick lines without prefixes and lines starting '+' prefix
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found
2014-09-04 13:16 [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found Masahiro Yamada
@ 2014-09-04 15:01 ` Stephen Warren
2014-09-17 0:46 ` [U-Boot] [U-Boot, " Tom Rini
2014-10-01 15:29 ` [U-Boot] [PATCH " York Sun
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Warren @ 2014-09-04 15:01 UTC (permalink / raw)
To: u-boot
On 09/04/2014 07:16 AM, Masahiro Yamada wrote:
> When a non-existing defconfig is specified,
> display an easy-to-understand message
> (fake the error message on Linux Kernel):
>
> $ make foo_defconfig
> ***
> *** Can't find default configuration "confis/foo_defconfig"!
> ***
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [U-Boot, v2] kconfig: show an error message when defconfig is not found
2014-09-04 13:16 [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found Masahiro Yamada
2014-09-04 15:01 ` Stephen Warren
@ 2014-09-17 0:46 ` Tom Rini
2014-10-01 15:29 ` [U-Boot] [PATCH " York Sun
2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2014-09-17 0:46 UTC (permalink / raw)
To: u-boot
On Thu, Sep 04, 2014 at 10:16:15PM +0900, Masahiro Yamada wrote:
> When a non-existing defconfig is specified,
> display an easy-to-understand message
> (fake the error message on Linux Kernel):
>
> $ make foo_defconfig
> ***
> *** Can't find default configuration "confis/foo_defconfig"!
> ***
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Acked-by: Stephen Warren <swarren@nvidia.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140916/faae78d9/attachment.pgp>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found
2014-09-04 13:16 [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found Masahiro Yamada
2014-09-04 15:01 ` Stephen Warren
2014-09-17 0:46 ` [U-Boot] [U-Boot, " Tom Rini
@ 2014-10-01 15:29 ` York Sun
2014-10-01 15:40 ` Masahiro YAMADA
2 siblings, 1 reply; 5+ messages in thread
From: York Sun @ 2014-10-01 15:29 UTC (permalink / raw)
To: u-boot
On 09/04/2014 06:16 AM, Masahiro Yamada wrote:
> When a non-existing defconfig is specified,
> display an easy-to-understand message
> (fake the error message on Linux Kernel):
>
> $ make foo_defconfig
> ***
> *** Can't find default configuration "confis/foo_defconfig"!
> ***
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> Changes in v2:
> - Echo the error message to stderr
>
> scripts/multiconfig.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/scripts/multiconfig.sh b/scripts/multiconfig.sh
> index a579042..49fcfad 100644
> --- a/scripts/multiconfig.sh
> +++ b/scripts/multiconfig.sh
> @@ -118,6 +118,13 @@ do_board_defconfig () {
> defconfig_path=$srctree/configs/$1
> tmp_defconfig_path=configs/.tmp_defconfig
>
> + if [ ! -r $defconfig_path ]; then
> + echo >&2 "***"
> + echo >&2 "*** Can't find default configuration \"confis/$1\"!"
s/confis/configs/
York
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found
2014-10-01 15:29 ` [U-Boot] [PATCH " York Sun
@ 2014-10-01 15:40 ` Masahiro YAMADA
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro YAMADA @ 2014-10-01 15:40 UTC (permalink / raw)
To: u-boot
Hi York.
2014-10-02 0:29 GMT+09:00 York Sun <yorksun@freescale.com>:
>> + if [ ! -r $defconfig_path ]; then
>> + echo >&2 "***"
>> + echo >&2 "*** Can't find default configuration \"confis/$1\"!"
>
> s/confis/configs/
>
Oops!
Thanks for spotting this.
Could send a patch, please?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-01 15:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 13:16 [U-Boot] [PATCH v2] kconfig: show an error message when defconfig is not found Masahiro Yamada
2014-09-04 15:01 ` Stephen Warren
2014-09-17 0:46 ` [U-Boot] [U-Boot, " Tom Rini
2014-10-01 15:29 ` [U-Boot] [PATCH " York Sun
2014-10-01 15:40 ` Masahiro YAMADA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox