public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: Fix length bug in ioread16_rep() and iowrite16_rep()
Date: Fri, 05 Sep 2014 10:06:48 +0200	[thread overview]
Message-ID: <54096F18.2000907@denx.de> (raw)
In-Reply-To: <1409903821-24398-1-git-send-email-sr@denx.de>

Hello Stefan,

Am 05.09.2014 09:57, schrieb Stefan Roese:
> The ioread16_rep() and iowrite16_rep() implementations are U-Boot specific
> and have been introduced with the Linux MTD v3.14 sync. While introducing
> these functions, the length for the loop has been miscalculated. The ">>  1"
> is already present in the caller. So lets remove it in the function.
>
> Tested on omap3_ha.
>
> Signed-off-by: Stefan Roese<sr@denx.de>
> Cc: Heiko Schocher<hs@denx.de>
> Cc: Tom Rini<trini@ti.com>
> Cc: Scott Wood<scottwood@freescale.com>
> ---
>   drivers/mtd/nand/nand_base.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Good catch, thanks!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-09-05  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05  7:57 [U-Boot] [PATCH] mtd: nand: Fix length bug in ioread16_rep() and iowrite16_rep() Stefan Roese
2014-09-05  8:06 ` Heiko Schocher [this message]
2014-09-24 11:03   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54096F18.2000907@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox