From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 01/17] arm: ls102xa: Add Freescale LS102xA SoC support
Date: Fri, 5 Sep 2014 09:45:16 -0700 [thread overview]
Message-ID: <5409E89C.1050304@freescale.com> (raw)
In-Reply-To: <20140905082347.10D4B380E22@gemini.denx.de>
On 09/05/2014 01:23 AM, Wolfgang Denk wrote:
> Dear Alison Wang,
>
> In message <1409895853-17736-2-git-send-email-alison.wang@freescale.com> you wrote:
>>
>> + unsigned long sysclk = CONFIG_SYS_CLK_FREQ;
>> +
>> + sys_info->freq_systembus = sysclk;
>> +#ifdef CONFIG_DDR_CLK_FREQ
>> + sys_info->freq_ddrbus = CONFIG_DDR_CLK_FREQ;
>> +#else
>> + sys_info->freq_ddrbus = sysclk;
>> +#endif
>
> I think this should be simplified into a
>
> #ifndef CONFIG_DDR_CLK_FREQ
> #define CONFIG_DDR_CLK_FREQ CONFIG_SYS_CLK_FREQ
> #endif
>
> somewhere in a header file, and getting rid of the #ifdef here?
>
Dear Wolfgang,
I prefer to stay this way. In the past for mpc85xx, DDR clock source could come
from a dedicated clock, or from the system clock. If it comes from the dedicated
clock, different care is needed to calculate the DDR ratio. This SoC may go that
path as well.
York
next prev parent reply other threads:[~2014-09-05 16:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 5:43 [U-Boot] [PATCH v6 0/17] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support Alison Wang
2014-09-05 5:43 ` [U-Boot] [PATCH v6 01/17] arm: ls102xa: Add Freescale LS102xA SoC support Alison Wang
2014-09-05 8:23 ` Wolfgang Denk
2014-09-05 16:45 ` York Sun [this message]
2014-09-05 5:43 ` [U-Boot] [PATCH v6 02/17] ls102xa: i2c: Add i2c support for LS102xA Alison Wang
2014-09-05 5:43 ` [U-Boot] [PATCH v6 03/17] net: Merge asm/fsl_enet.h into fsl_mdio.h Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 04/17] net: mdio: Use mb() to be compatible for both ARM and PowerPC Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 05/17] ls102xa: etsec: Add etsec support for LS102xA Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 06/17] esdhc: Add CONFIG_SYS_FSL_ESDHC_LE and CONFIG_SYS_FSL_ESDHC_BE macros Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 07/17] ls102xa: esdhc: Add esdhc support for LS102xA Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 08/17] driver/ddr/freescale: Add support of accumulate ECC Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 09/17] driver/ddr/freescale: Fix DDR3 driver for ARM Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 10/17] driver/ddr/fsl: Add support of overriding chip select write leveling Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 11/17] arm: ls102xa: Add basic support for LS1021AQDS board Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 12/17] arm: ls102xa: Add basic support for LS1021ATWR board Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 13/17] net: tsec: Remove tx snooping support from LS1 Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 14/17] serial: lpuart: add 32-bit registers lpuart support Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 15/17] video: dcu: Add DCU driver support Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 16/17] video: dcu: Add Sii9022A HDMI Transmitter support Alison Wang
2014-09-05 5:44 ` [U-Boot] [PATCH v6 17/17] ls102xa: dcu: Add platform support for DCU on LS1021ATWR board Alison Wang
-- strict thread matches above, loose matches on Subject: below --
2014-09-05 5:52 [U-Boot] [PATCH v6 0/17] arm: ls102xa: Add Freescale LS102xA SoC and LS1021AQDS/TWR board support Alison Wang
2014-09-05 5:52 ` [U-Boot] [PATCH v6 01/17] arm: ls102xa: Add Freescale LS102xA SoC support Alison Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409E89C.1050304@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox