public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: drEagle <drEagle@doukki.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] ARM: sheevaplug: fix uboot corruption
Date: Sat, 06 Sep 2014 08:50:48 +0200	[thread overview]
Message-ID: <540AAEC8.1010406@doukki.net> (raw)
In-Reply-To: <1406440476-7552-1-git-send-email-drEagle@doukki.net>

Hi,

Is there any chance for this patch to be upstreamed in the next release ?

On sheevaplug if you try the latest u-boot you may be brick the plug.
It will be corrupted because of the size of the of the u-boot binary.

The fix of env location proposed is a needed fix.

I have still some few patch to propose been mainlined next this one.
Is the marvell u-boot custodian still active ?

Enjoy,

On 27/07/2014 07:54, Gerald Kerma wrote:
> This patch move the environment offset in sheevaplug.
> The size of the u-boot binary is become too big.
> Saving environments will result of corrupting the u-boot.
> 
> Signed-off-by: Gerald Kerma <drEagle@doukki.net>
> ---
> 
>  Changes in v1:
>  - fix sheevaplug environment offset
> 
>  include/configs/sheevaplug.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> index 3d6ff09..85c6bc2 100644
> --- a/include/configs/sheevaplug.h
> +++ b/include/configs/sheevaplug.h
> @@ -55,8 +55,8 @@
>   * it has to be rounded to sector size
>   */
>  #define CONFIG_ENV_SIZE			0x20000	/* 128k */
> -#define CONFIG_ENV_ADDR			0x60000
> -#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
> +#define CONFIG_ENV_ADDR			0x80000
> +#define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
>  
>  /*
>   * Default environment variables
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140906/88ce906e/attachment.pgp>

      reply	other threads:[~2014-09-06  6:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-27  5:54 [U-Boot] [PATCH 1/1] ARM: sheevaplug: fix uboot corruption Gerald Kerma
2014-09-06  6:50 ` drEagle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540AAEC8.1010406@doukki.net \
    --to=dreagle@doukki.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox