[U-Boot] [PATCH 1/1] ARM: sheevaplug: fix uboot corruption

[U-Boot] [PATCH 1/1] ARM: sheevaplug: fix uboot corruption

[Gerald Kerma]

This patch move the environment offset in sheevaplug.
The size of the u-boot binary is become too big.
Saving environments will result of corrupting the u-boot.

Signed-off-by: Gerald Kerma <drEagle@doukki.net>
---

 Changes in v1:
 - fix sheevaplug environment offset

 include/configs/sheevaplug.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
index 3d6ff09..85c6bc2 100644
--- a/include/configs/sheevaplug.h
+++ b/include/configs/sheevaplug.h
@@ -55,8 +55,8 @@
  * it has to be rounded to sector size
  */
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
-#define CONFIG_ENV_ADDR			0x60000
-#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
+#define CONFIG_ENV_ADDR			0x80000
+#define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
 
 /*
  * Default environment variables
-- 
1.9.1

[U-Boot] [PATCH 1/1] ARM: sheevaplug: fix uboot corruption

[drEagle]

Hi,

Is there any chance for this patch to be upstreamed in the next release ?

On sheevaplug if you try the latest u-boot you may be brick the plug.
It will be corrupted because of the size of the of the u-boot binary.

The fix of env location proposed is a needed fix.

I have still some few patch to propose been mainlined next this one.
Is the marvell u-boot custodian still active ?

Enjoy,

On 27/07/2014 07:54, Gerald Kerma wrote:
> This patch move the environment offset in sheevaplug.
> The size of the u-boot binary is become too big.
> Saving environments will result of corrupting the u-boot.
> 
> Signed-off-by: Gerald Kerma <drEagle@doukki.net>
> ---
> 
>  Changes in v1:
>  - fix sheevaplug environment offset
> 
>  include/configs/sheevaplug.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> index 3d6ff09..85c6bc2 100644
> --- a/include/configs/sheevaplug.h
> +++ b/include/configs/sheevaplug.h
> @@ -55,8 +55,8 @@
>   * it has to be rounded to sector size
>   */
>  #define CONFIG_ENV_SIZE			0x20000	/* 128k */
> -#define CONFIG_ENV_ADDR			0x60000
> -#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */
> +#define CONFIG_ENV_ADDR			0x80000
> +#define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
>  
>  /*
>   * Default environment variables
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140906/88ce906e/attachment.pgp>