From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFCv2] mainline u-boot on socfpga
Date: Mon, 08 Sep 2014 14:35:26 +0200 [thread overview]
Message-ID: <540DA28E.3000407@monstr.eu> (raw)
In-Reply-To: <20140908120845.GA19660@amd>
Hi Pavel,
On 09/08/2014 02:08 PM, Pavel Machek wrote:
> Hi!
>
> I know coding style leaves something to be desired.
It is more than this. Also SPDX license headers, etc.
> But.. it recognizes MMC/ethernet, and can load linux kernel.
>
> Unfortunately, 1MB of memory at 0 is not available for some reason;
> but linux works ok if you avoid that area.
>
> "fpga load 0" now seems to work.
>
> For some reason, I had to rewrite fpgamgr_axi_write(). There's some
> bug in assembly version, causing code to get confused after it is
> executed.
>
> If some ARM expert could take a look, that would be great; bug is
> likely also present in rocketboards version of u-boot.
>
I have quickly looked at this patch and there are a lot of things in one patch
and it is not possible to even quickly review. Please create patches
with proper description and then we can review.
For drivers/fpga/altera.c please look at xilinx wrappers and change altera
code based on that. Hopefully you can add all fpga code to drivers/fpga.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140908/5be79fcb/attachment.pgp>
next prev parent reply other threads:[~2014-09-08 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 19:34 [U-Boot] [RFC] mainline u-boot on socfpga Pavel Machek
2014-09-08 12:08 ` [U-Boot] [RFCv2] " Pavel Machek
2014-09-08 12:35 ` Michal Simek [this message]
2014-09-15 7:12 ` Chin Liang See
2014-09-15 7:31 ` Chin Liang See
2014-09-15 8:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540DA28E.3000407@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox