public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7 2/2] net: fec_mxc: Poll FEC_TBD_READY after polling TDAR
Date: Tue, 09 Sep 2014 15:10:24 +0200	[thread overview]
Message-ID: <540EFC40.2070802@denx.de> (raw)
In-Reply-To: <1408984457-10272-2-git-send-email-fabio.estevam@freescale.com>

On 25/08/2014 18:34, Fabio Estevam wrote:
> When testing the FEC driver on a mx6solox we noticed that the TDAR bit gets
> always cleared prior then the READY bit is cleared in the last BD, which causes
> FEC packets reception to always fail.
> 
> As explained by Ye Li:
> 
> "The TDAR bit is cleared when the descriptors are all out from TX ring, but on 
> mx6solox we noticed that the READY bit is still not cleared right after TDAR. 
> These are two distinct signals, and in IC simulation, we found that TDAR always
> gets cleared prior than the READY bit of last BD becomes cleared. 
> In mx6solox, we use a later version of FEC IP. It looks like that this 
> intrinsic behaviour of TDAR bit has changed in this newer FEC version."
> 
> Fix this by polling the READY bit of BD after the TDAR polling, which covers the
> mx6solox case and does not harm the other SoCs.
> 
> No performance drop has been noticed with this patch applied when testing TFTP
> transfers on several boards of different i.mx SoCs.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2014-09-09 13:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 16:34 [U-Boot] [PATCH v7 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox Fabio Estevam
2014-08-25 16:34 ` [U-Boot] [PATCH v7 2/2] net: fec_mxc: Poll FEC_TBD_READY after polling TDAR Fabio Estevam
2014-08-25 19:51   ` Marek Vasut
2014-09-09 13:10   ` Stefano Babic [this message]
2014-08-25 19:51 ` [U-Boot] [PATCH v7 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox Marek Vasut
2014-08-30 17:22   ` Fabio Estevam
2014-08-30 19:21     ` Tom Rini
2014-09-08 23:52       ` Fabio Estevam
2014-09-09 13:09         ` Stefano Babic
2014-09-09 13:37           ` Fabio Estevam
2014-09-03 22:21 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540EFC40.2070802@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox