[U-Boot] [PATCH] imximage: Fix imximage IVT bug for EIM-NOR boot

Stefano Babic
2014-09-09T14:38:40Z

Hi Ye,

On 21/08/2014 09:04, Li Ye-B37916 wrote:

> There are two minor impacts if putting the check in the function
> "parse_cfg_cmd":
>
> 1. The "imximage_version" must be got before parsing a CMD_BOOT_FROM
> command. This compels the CMD_IMAGE_VERSION preceding the
> CMD_BOOT_FROM in script. imximage_init_loadsize is only needed by V2
> version.

I know abot this, and this is a minor impact. It is common that a
version number of a document must be set first in the document.

>
> 2. Since the "imximage_generate" function already implements post
> fixing for imximage_init_loadsize, this post fixing needs be
> removed.
>
> Actually, putting the check in the parsing or post the parsing are ok
> for me. Both can resolve the issue. The comment for
> "FLASH_LOADSIZE_NOR" sources from iMX reference manual, it is
> correct.

Well, I think it is clear for both of us because we worked with i-IM
images. But setting a size to 0x0 with the comment that this is the size
of whole image can be confusing (I think I was the author of this
comment, so I am guilty for that). Anyway, it is a very minor issue.

I hope that people will read carefully the manual together with code.

Anyway, comments are very minor issues - I will apply the patch.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================