From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] env_mmc: correct fini partition to match init partition
Date: Tue, 09 Sep 2014 18:25:59 +0300 [thread overview]
Message-ID: <540F1C07.6000408@compulab.co.il> (raw)
In-Reply-To: <1409764963-9617-1-git-send-email-pab@pabigot.com>
Hi Peter,
On 09/03/14 20:22, Peter A. Bigot wrote:
> The code to set the MMC partition uses an weak function to obtain the
> correct partition number. Use that instead of the compile-time default
> when deciding whether it needs to switch back.
>
> Fixes: 6e7b7df4df43574 ("env_mmc: support env partition setup in runtime")
It is sometimes also useful to Cc the original author of the patch.
Cc: Dmitry Lifshitz <lifshitz@compulab.co.il>
> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
> ---
> V3:
> * Add Fixes line as requested
>
> V2:
> * Preserve desired behavior of avoiding diagnostic when no HW partition supported
> * Supersedes https://patchwork.ozlabs.org/patch/385355/
>
> common/env_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/env_mmc.c b/common/env_mmc.c
> index a7621a8..14648e3 100644
> --- a/common/env_mmc.c
> +++ b/common/env_mmc.c
> @@ -113,7 +113,7 @@ static void fini_mmc_for_env(struct mmc *mmc)
> #ifdef CONFIG_SPL_BUILD
> dev = 0;
> #endif
> - if (CONFIG_SYS_MMC_ENV_PART != mmc->part_num)
> + if (mmc_get_env_part(mmc) != mmc->part_num)
> mmc_switch_part(dev, mmc->part_num);
> #endif
> }
>
--
Regards,
Igor.
next prev parent reply other threads:[~2014-09-09 15:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 23:31 [U-Boot] [PATCH 0/2] fix issue with mmc partition management Peter A. Bigot
2014-09-02 23:31 ` [U-Boot] [PATCH 1/2] env_mmc: remove condition on call to mmc_switch_part Peter A. Bigot
2014-09-03 15:46 ` Stephen Warren
2014-09-03 16:03 ` Peter A. Bigot
2014-09-03 16:32 ` [U-Boot] [PATCH v2] env_mmc: correct fini partition to match init partition Peter A. Bigot
2014-09-03 16:52 ` Stephen Warren
2014-09-03 17:30 ` Peter A. Bigot
2014-09-03 17:46 ` Stephen Warren
2014-09-03 17:55 ` Peter A. Bigot
2014-09-03 17:22 ` [U-Boot] [PATCH v3] " Peter A. Bigot
2014-09-09 15:25 ` Igor Grinberg [this message]
2014-09-14 13:21 ` Dmitry Lifshitz
2014-10-02 11:09 ` Pantelis Antoniou
2014-09-02 23:31 ` [U-Boot] [PATCH 2/2] mmc: restore capacity when switching to partition 0 Peter A. Bigot
2014-09-03 15:48 ` Stephen Warren
2014-09-03 15:59 ` Peter A. Bigot
2014-09-03 16:05 ` Stephen Warren
2014-09-03 16:36 ` Peter A. Bigot
2014-09-11 17:45 ` Tom Rini
2014-10-02 11:07 ` Pantelis Antoniou
2014-09-11 15:57 ` [U-Boot] [PATCH 0/2] fix issue with mmc partition management Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F1C07.6000408@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox