[U-Boot] [PATCH v2 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only

[U-Boot] [PATCH v2 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only

[Heiko Schocher]

This patchserie allows fullspeed for DFU, and configures the
siemens boards to use fullspeed only.

- changes for v2:
  - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
    suggested.

Cc: Tom Rini <trini@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Liu Bin <b-liu@ti.com>
Cc: Lukas Stockmann <lukas.stockmann@siemens.com>

Heiko Schocher (2):
  usb: dfu: add fullspeed support for DFU
  arm: am335x: siemens board use in DFU mode fullspeed only

 drivers/usb/gadget/f_dfu.c             | 3 +++
 include/configs/siemens-am33x-common.h | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU

[Heiko Schocher]

DFU now can use also fullspeed.

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Liu Bin <b-liu@ti.com>
Cc: Lukas Stockmann <lukas.stockmann@siemens.com>

---

- changes for v2:
  - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
    suggested.
---
 drivers/usb/gadget/f_dfu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
 {
 	f_dfu->usb_function.strings = dfu_strings;
 	f_dfu->usb_function.hs_descriptors = f_dfu->function;
+	f_dfu->usb_function.descriptors = f_dfu->function;
 	f_dfu->dfu_state = DFU_STATE_dfuIDLE;
 }
 
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
 {
 	f_dfu->usb_function.strings = NULL;
 	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+	f_dfu->usb_function.descriptors = dfu_runtime_descs;
 }
 
 static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
 		return -ENOMEM;
 	f_dfu->usb_function.name = "dfu";
 	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+	f_dfu->usb_function.descriptors = dfu_runtime_descs;
 	f_dfu->usb_function.bind = dfu_bind;
 	f_dfu->usb_function.unbind = dfu_unbind;
 	f_dfu->usb_function.set_alt = dfu_set_alt;
-- 
1.8.3.1

[U-Boot] [PATCH v2 2/2] arm: am335x: siemens board use in DFU mode fullspeed only

[Heiko Schocher]

Siemens boards are now using DFU in fullspeed only. For
this CONFIG_USB_GADGET_DUALSPEED is undefined.

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Liu Bin <b-liu@ti.com>
Cc: Lukas Stockmann <lukas.stockmann@siemens.com>

---

On the siemens board this is needed  because of a
protection circuit. The device is 24V AC powered,
if someone uses a non galvanically isolated transformer
and misswires it, it could burn down the USB host.
That's why we have a protection on the USB side which
limits the speed to 12Mbit/sec.

- changes for v2:
  - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
    suggested.
---
 include/configs/siemens-am33x-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h
index b8fb77e..4dcd690 100644
--- a/include/configs/siemens-am33x-common.h
+++ b/include/configs/siemens-am33x-common.h
@@ -233,7 +233,7 @@
 #define CONFIG_MUSB_GADGET
 #define CONFIG_MUSB_PIO_ONLY
 #define CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT
-#define CONFIG_USB_GADGET_DUALSPEED
+#undef CONFIG_USB_GADGET_DUALSPEED
 #define CONFIG_USB_GADGET_VBUS_DRAW	2
 #define CONFIG_MUSB_HOST
 
-- 
1.8.3.1

[U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU

[Bin Liu]

Heiko,

On 09/10/2014 01:55 AM, Heiko Schocher wrote:
> DFU now can use also fullspeed.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Liu Bin <b-liu@ti.com>

My first name is Bin.

Other than that, feel free to add

Reviewed by: Bin Liu <b-liu@ti.com>

Regards,
-Bin.

> Cc: Lukas Stockmann <lukas.stockmann@siemens.com>
>
> ---
>
> - changes for v2:
>    - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
>      suggested.
> ---
>   drivers/usb/gadget/f_dfu.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> index 1145aab..dfa9f3b 100644
> --- a/drivers/usb/gadget/f_dfu.c
> +++ b/drivers/usb/gadget/f_dfu.c
> @@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
>   {
>   	f_dfu->usb_function.strings = dfu_strings;
>   	f_dfu->usb_function.hs_descriptors = f_dfu->function;
> +	f_dfu->usb_function.descriptors = f_dfu->function;
>   	f_dfu->dfu_state = DFU_STATE_dfuIDLE;
>   }
>
> @@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
>   {
>   	f_dfu->usb_function.strings = NULL;
>   	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>   }
>
>   static int handle_upload(struct usb_request *req, u16 len)
> @@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
>   		return -ENOMEM;
>   	f_dfu->usb_function.name = "dfu";
>   	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>   	f_dfu->usb_function.bind = dfu_bind;
>   	f_dfu->usb_function.unbind = dfu_unbind;
>   	f_dfu->usb_function.set_alt = dfu_set_alt;
>

[U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU

[Lukasz Majewski]

Hi Heiko,

> DFU now can use also fullspeed.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Liu Bin <b-liu@ti.com>
> Cc: Lukas Stockmann <lukas.stockmann@siemens.com>
> 
> ---
> 
> - changes for v2:
>   - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
>     suggested.
> ---
>  drivers/usb/gadget/f_dfu.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> index 1145aab..dfa9f3b 100644
> --- a/drivers/usb/gadget/f_dfu.c
> +++ b/drivers/usb/gadget/f_dfu.c
> @@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu
> *f_dfu) {
>  	f_dfu->usb_function.strings = dfu_strings;
>  	f_dfu->usb_function.hs_descriptors = f_dfu->function;
> +	f_dfu->usb_function.descriptors = f_dfu->function;
>  	f_dfu->dfu_state = DFU_STATE_dfuIDLE;
>  }
>  
> @@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu
> *f_dfu) {
>  	f_dfu->usb_function.strings = NULL;
>  	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>  }
>  
>  static int handle_upload(struct usb_request *req, u16 len)
> @@ -809,6 +811,7 @@ static int dfu_bind_config(struct
> usb_configuration *c) return -ENOMEM;
>  	f_dfu->usb_function.name = "dfu";
>  	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>  	f_dfu->usb_function.bind = dfu_bind;
>  	f_dfu->usb_function.unbind = dfu_unbind;
>  	f_dfu->usb_function.set_alt = dfu_set_alt;

Test HW: Exynos 4412 - Trats2

This patch seems to not introduce any regressions, so

Tested-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU

[Lukasz Majewski]

Hi Heiko,

> DFU now can use also fullspeed.

Applied to u-boot-dfu

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[U-Boot] [PATCH v2 2/2] arm: am335x: siemens board use in DFU mode fullspeed only

[Lukasz Majewski]

Hi Heiko,

> Siemens boards are now using DFU in fullspeed only. For
> this CONFIG_USB_GADGET_DUALSPEED is undefined.

Applied to u-boot-dfu

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group