From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter A. Bigot Date: Wed, 10 Sep 2014 09:50:21 -0500 Subject: [U-Boot] commit 83e359adf9f578a58f20daf2e4425a754defac7b breaks mmc In-Reply-To: <20140909172754.GS6151@saruman.home> References: <20140909170902.GR6151@saruman.home> <20140909172754.GS6151@saruman.home> Message-ID: <5410652D.9060701@pabigot.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/09/2014 12:27 PM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 09, 2014 at 12:09:02PM -0500, Felipe Balbi wrote: >> Hi, >> >> commit 83e359a (am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT) >> breaks MMC on some boards. I believe it only breaks if EMMC has no >> partition on it, so that would point out to a bug on spl env support >> itself and this has only exposed it. >> >> Here's a bisection log anyway: >> >> git bisect start >> # good: [524123a70761110c5cf3ccc5f52f6d4da071b959] Prepare v2014.07 >> git bisect good 524123a70761110c5cf3ccc5f52f6d4da071b959 >> # bad: [0b703dbcee7103f07804d0a4328d1593355c4324] patman: Fix detection of git version >> git bisect bad 0b703dbcee7103f07804d0a4328d1593355c4324 >> # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout >> git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 >> # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout >> git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 >> # good: [04b43f32731c1171877541050bb3f2bfeb100e3d] tools/genboardscfg.py: ignore defconfigs starting with a dot >> git bisect good 04b43f32731c1171877541050bb3f2bfeb100e3d >> # bad: [6defdc0b5552ab1af4a66a8abac8196cbb6b9e15] Merge branch 'master' of git://git.denx.de/u-boot-ti >> git bisect bad 6defdc0b5552ab1af4a66a8abac8196cbb6b9e15 >> # good: [6af857c50df4e62ec08e51ad73c96f63f1480386] Merge branch 'master' of http://git.denx.de/u-boot-sunxi >> git bisect good 6af857c50df4e62ec08e51ad73c96f63f1480386 >> # good: [7f14fb20f895016fb38d30ce71aeb4d441b5bcb8] Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze >> git bisect good 7f14fb20f895016fb38d30ce71aeb4d441b5bcb8 >> # bad: [61f66fd5a81b97478e9d14326c1059baa6626680] keystone2: use EFUSE_BOOTROM information to configure PLLs >> git bisect bad 61f66fd5a81b97478e9d14326c1059baa6626680 >> # bad: [fea9543f1bd1d068a372ef378f624941c25989a8] board/ti/am335x: update configs for parallel NAND >> git bisect bad fea9543f1bd1d068a372ef378f624941c25989a8 >> # good: [e017fd61c5a89e32db682d94d8d669df1709edbb] tseries: Set CONFIG_ENV_IS_NOWHERE for SPL+NAND >> git bisect good e017fd61c5a89e32db682d94d8d669df1709edbb >> # bad: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT >> git bisect bad 83e359adf9f578a58f20daf2e4425a754defac7b >> # good: [00e385325fce36fa13d48091d73b1b3428394b6b] common/Makefile: Consolidate SPL ENV options, correct inclusion >> git bisect good 00e385325fce36fa13d48091d73b1b3428394b6b >> # first bad commit: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT >> >> Revert that commit also makes it work, btw. >> >> On a further dig into this, it looks like when enabling >> CONFIG_SPL_ENV_SUPPORT, somehow MMC numbering changes and u-boot ends up >> trying to read environment from a non-formatted EMMC. > forgot to mention, this is all on BBB and affects only am335x-based > boards, of course. I believe this is the problem that https://patchwork.ozlabs.org/patch/385354/ is intended to fix. See also discussion at http://www.mail-archive.com/u-boot at lists.denx.de/msg146396.html Peter