From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] exynos: Move common smdk5420 things to common file
Date: Thu, 11 Sep 2014 16:38:29 +0900 [thread overview]
Message-ID: <54115175.1030502@samsung.com> (raw)
In-Reply-To: <1406117482-2391-4-git-send-email-sjg@chromium.org>
Dear Simon Glass,
On 23/07/14 21:11, Simon Glass wrote:
> A few things are common but are not in the common file. Fix this and
> rename the file to fit with the other exynos*-common files.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> include/configs/{exynos5420.h => exynos5420-common.h} | 11 ++++++-----
> include/configs/peach-pit.h | 7 +------
> include/configs/smdk5420.h | 7 +------
> 3 files changed, 8 insertions(+), 17 deletions(-)
> rename include/configs/{exynos5420.h => exynos5420-common.h} (88%)
>
> diff --git a/include/configs/exynos5420.h b/include/configs/exynos5420-common.h
> similarity index 88%
> rename from include/configs/exynos5420.h
> rename to include/configs/exynos5420-common.h
> index d2a9556..685f9c1 100644
> --- a/include/configs/exynos5420.h
> +++ b/include/configs/exynos5420-common.h
> @@ -9,7 +9,9 @@
> #ifndef __CONFIG_EXYNOS5420_H
> #define __CONFIG_EXYNOS5420_H
>
> -#define CONFIG_EXYNOS5420 /* which is in a Exynos5 Family */
> +#define CONFIG_EXYNOS5420
> +
> +#include <configs/exynos5-common.h>
>
> #define MACH_TYPE_SMDK5420 8002
> #define CONFIG_MACH_TYPE MACH_TYPE_SMDK5420
> @@ -31,10 +33,6 @@
>
> #define CONFIG_MAX_I2C_NUM 11
>
> -/* Enable FIT support and comparison */
> -#define CONFIG_FIT
> -#define CONFIG_FIT_BEST_MATCH
> -
> #define CONFIG_BOARD_REV_GPIO_COUNT 2
>
> #define CONFIG_BOOTCOMMAND "mmc read 20007000 451 2000; bootm 20007000"
> @@ -49,4 +47,7 @@
> #define CONFIG_NR_DRAM_BANKS 7
> #define SDRAM_BANK_SIZE (512UL << 20UL) /* 512 MB */
>
> +/* select serial console configuration */
> +#define CONFIG_SERIAL3 /* use SERIAL 3 */
I think it's a board specific feature.
> +
> #endif /* __CONFIG_EXYNOS5420_H */
> diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h
> index 59192e1..407f10f 100644
> --- a/include/configs/peach-pit.h
> +++ b/include/configs/peach-pit.h
> @@ -9,16 +9,11 @@
> #ifndef __CONFIG_PEACH_PIT_H
> #define __CONFIG_PEACH_PIT_H
>
> -#include <configs/exynos5-common.h>
> -
> -#include <configs/exynos5420.h>
> +#include <configs/exynos5420-common.h>
>
> #undef CONFIG_DEFAULT_DEVICE_TREE
> #define CONFIG_DEFAULT_DEVICE_TREE exynos5420-peach-pit
>
> -/* select serial console configuration */
> -#define CONFIG_SERIAL3 /* use SERIAL 3 */
> -
> #define CONFIG_SYS_PROMPT "Peach # "
> #define CONFIG_IDENT_STRING " for Peach"
>
> diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h
> index 43c9808..83abc13 100644
> --- a/include/configs/smdk5420.h
> +++ b/include/configs/smdk5420.h
> @@ -9,18 +9,13 @@
> #ifndef __CONFIG_SMDK5420_H
> #define __CONFIG_SMDK5420_H
>
> -#include <configs/exynos5-common.h>
> -
> -#include <configs/exynos5420.h>
> +#include <configs/exynos5420-common.h>
>
> #define CONFIG_SMDK5420 /* which is in a SMDK5420 */
>
> #undef CONFIG_DEFAULT_DEVICE_TREE
> #define CONFIG_DEFAULT_DEVICE_TREE exynos5420-smdk5420
>
> -/* select serial console configuration */
> -#define CONFIG_SERIAL3 /* use SERIAL 3 */
> -
> #define CONFIG_SYS_PROMPT "SMDK5420 # "
> #define CONFIG_IDENT_STRING " for SMDK5420"
>
>
Thanks,
Minkyu Kang.
next prev parent reply other threads:[~2014-09-11 7:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:11 [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted) Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 1/8] exynos: Rename -dt config files to -common Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 2/8] exynos: Move common exynos settings into a common file Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 3/8] exynos: Move common smdk5420 things to " Simon Glass
2014-09-11 7:38 ` Minkyu Kang [this message]
2014-09-14 18:31 ` Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 4/8] exynos: config: Move cros_ec and tps65090 out of smdk boards Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 5/8] config: Move arndale to use common exynos5250 file Simon Glass
2014-09-11 7:38 ` Minkyu Kang
2014-09-14 18:29 ` Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 6/8] config: Move smdkv310 to use common exynos4 file Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 7/8] samsung: Move s5p_goni to use exynos-common config Simon Glass
2014-09-09 10:26 ` Przemyslaw Marczak
2014-09-09 19:37 ` Simon Glass
2014-07-23 12:11 ` [U-Boot] [PATCH 8/8] samsung: Move smdkc100 " Simon Glass
2014-09-09 10:26 ` Przemyslaw Marczak
2014-07-24 8:34 ` [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted) Lukasz Majewski
2014-07-25 14:43 ` Simon Glass
2014-09-09 6:05 ` Simon Glass
2014-09-09 10:31 ` Przemyslaw Marczak
2014-09-12 8:39 ` Przemyslaw Marczak
2014-09-12 14:48 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54115175.1030502@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox