public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Li Ye-B37916 <b37916@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/4] imx: mx6sabresd: Add clear print for pfuze200
Date: Fri, 12 Sep 2014 19:40:06 +0800	[thread overview]
Message-ID: <5412DB96.3070100@freescale.com> (raw)
In-Reply-To: <5412C739.8030306@denx.de>

Hi Stefano,

On 9/12/2014 6:13 PM, Stefano Babic wrote:
> Hi Ye,
>
> On 11/09/2014 05:13, Ye.Li wrote:
>> Add clear print log to show pfuze200 or pfuze100 found on mx6sabresd.
>>
>> Signed-off-by: Ye.Li <B37916@freescale.com>
>> ---
>> Changes since v1:
>> - None
>>
>> Changes since v2:
>> - None
>>
>>  board/freescale/mx6sabresd/mx6sabresd.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
>> index 5f65f1b..72d6562 100644
>> --- a/board/freescale/mx6sabresd/mx6sabresd.c
>> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
>> @@ -472,7 +472,8 @@ static int pfuze_init(void)
>>  		return ret;
>>  
>>  	pmic_reg_read(p, PFUZE100_DEVICEID, &reg);
>> -	printf("PMIC:  PFUZE100 ID=0x%02x\n", reg);
>> +	printf("PMIC:  PFUZE%s ID=0x%02x\n",
>> +		((reg & 0xf) == 0) ? "100" : "200", reg);
>>  
>>  	/* Increase VGEN3 from 2.5 to 2.8V */
>>  	pmic_reg_read(p, PFUZE100_VGEN3VOL, &reg);
>>
> This is completely unrelated to the series - it can be applied
> independently from the other patches. You do not need to resend this one
> but please send in future patches belonging to the same series if they
> are related to the same issue or to the same set of issues. This
> simplifies review and merging - thanks !
>
> Acked-by: Stefano Babic <sbabic@denx.de>
>
> Best regards,
> Stefano Babic
>

Thanks for your comments. I feel this patch has somewhat relation with others, that in 4/4 the pfuze mode setup needs to consider the pfuze chip type. Of course, this patch can be applied independently.  I will be more careful about the patch set in future.

Best regards,
Ye Li

  reply	other threads:[~2014-09-12 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  3:13 [U-Boot] [PATCH v3 1/4] imx: mx6slevk: Add I2C1 support Ye.Li
2014-09-11  3:13 ` [U-Boot] [PATCH v3 2/4] imx: mx6slevk: Add PMIC Pfuze support Ye.Li
2014-09-11  3:13 ` [U-Boot] [PATCH v3 3/4] imx: mx6sabresd: Add clear print for pfuze200 Ye.Li
2014-09-12 10:13   ` Stefano Babic
2014-09-12 11:40     ` Li Ye-B37916 [this message]
2014-09-11  3:13 ` [U-Boot] [PATCH v3 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM Ye.Li
2014-09-12 10:08 ` [U-Boot] [PATCH v3 1/4] imx: mx6slevk: Add I2C1 support Stefano Babic
2014-09-12 10:29   ` Li Ye-B37916

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5412DB96.3070100@freescale.com \
    --to=b37916@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox