From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 08 Nov 2020 14:25:25 +0100 Subject: [PATCH] env: env_sf: don't set .init op if not needed In-Reply-To: <20201106204557.GG5340@bill-the-cat> References: <20201101133812.18701-1-michael@walle.cc> <287855.1604321503@gemini.denx.de> <305086.1604389962@gemini.denx.de> <8ff3b8ad-8c4e-fe99-69c8-7c174e997a49@prevas.dk> <391556.1604594414@gemini.denx.de> <20201106204557.GG5340@bill-the-cat> Message-ID: <541405.1604841925@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom, In message <20201106204557.GG5340@bill-the-cat> you wrote: > > > Later (208bd2b8), _NOWHERE was made non-mutually-exclusive with the real > > storage targets. > > Yes. It's intentional that "NOWHERE" means that if this is our run-time > location for the environment, then you cannot save the environment. But > since we finally implemented the ability to have more than one option > enabled and pick the correct one at run time, we build both "mmc" and > "nowhere". But this breaks logic. If you wanna have a nulldev, than implement a /dev/null. CONFIG_ENV_IS_NOWHERE should be the means to be used when no environment storage drivers are needed / selected, not even /dev/null. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de My challenge to the goto-less programmer is to recode tcp_input() without any gotos ... without any loss of efficiency (there has to be a catch). - W. R. Stevens