public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board
Date: Sun, 14 Sep 2014 11:53:00 -0700	[thread overview]
Message-ID: <5415E40C.2080509@boundarydevices.com> (raw)
In-Reply-To: <1410429592-10456-1-git-send-email-guillaume.gardet@free.fr>

Hi Guillaume,

On 09/11/2014 02:59 AM, Guillaume GARDET wrote:
> Sabrelite board has two solts: 0 is SD3 (bottom) slot and 1 is uSD4 (top) slot.
> This patch makes use of both slots instead of only one.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Eric Nelson <eric.nelson@boundarydevices.com>
> 
> ---
>  include/configs/nitrogen6x.h | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)
> 
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index d4b0ac9..2a1eb3b 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -186,7 +186,7 @@
>  	"fdt_addr=0x18000000\0" \
>  	"boot_fdt=try\0" \
>  	"ip_dyn=yes\0" \
> -	"mmcdev=0\0" \
> +	"mmcdevs=0 1\0" \
>  	"mmcpart=1\0" \
>  	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
>  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
> @@ -238,16 +238,19 @@
>  		"fi;\0"
>  
>  #define CONFIG_BOOTCOMMAND \
> -	   "mmc dev ${mmcdev}; if mmc rescan; then " \
> -		   "if run loadbootscript; then " \
> -			   "run bootscript; " \
> -		   "else " \
> -			   "if run loaduimage; then " \
> -				   "run mmcboot; " \
> -			   "else run netboot; " \
> -			   "fi; " \
> -		   "fi; " \
> -	   "else run netboot; fi"

If you add one more loop here, you'll end up with something
very close to the Nitrogen6x configuration!

> +	"for mmcdev in ${mmcdevs}; do " \
> +		"mmc dev ${mmcdev}; " \
> +		"if mmc rescan; then " \
> +			"if run loadbootscript; then " \
> +				"run bootscript; " \
> +			"else " \
> +				"if run loaduimage; then " \
> +					"run mmcboot; " \
> +				"fi; " \
> +			"fi; " \
> +		"fi; " \
> +	"done; " \
> +	"run netboot; "
>  #else
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"console=ttymxc1\0" \
> 

Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>

  reply	other threads:[~2014-09-14 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  9:59 [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board Guillaume GARDET
2014-09-14 18:53 ` Eric Nelson [this message]
2014-09-14 18:53 ` Eric Nelson
2014-09-22 13:53 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5415E40C.2080509@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox