public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC
Date: Mon, 15 Sep 2014 18:08:06 +0800	[thread overview]
Message-ID: <5416BA86.50306@atmel.com> (raw)
In-Reply-To: <1409646189-14294-1-git-send-email-boris.brezillon@free-electrons.com>

Hi, Boris

On 9/2/2014 4:23 PM, Boris BREZILLON wrote:
> Disable subpage write when using PMECC to prevent buggy partial page write.
>
> This fix has been taken from linux sources (see commit
> 90445ff6241e2a13445310803e2efa606c61f276)
>
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

Sorry for the later reply. And
Acked-by: Josh Wu <josh.wu@atmel.com>

Best Regards,
Josh Wu

> ---
> Hi,
>
> Here is a link to the linux commit:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276
>
> Best Regards,
>
> Boris
>
>   drivers/mtd/nand/atmel_nand.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e73834d..ee67662 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -881,6 +881,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
>   		return -ENOMEM;
>   	}
>   
> +	nand->options |= NAND_NO_SUBPAGE_WRITE;
>   	nand->ecc.read_page = atmel_nand_pmecc_read_page;
>   	nand->ecc.write_page = atmel_nand_pmecc_write_page;
>   	nand->ecc.strength = cap;

  reply	other threads:[~2014-09-15 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  8:23 [U-Boot] [PATCH] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC Boris BREZILLON
2014-09-15 10:08 ` Josh Wu [this message]
2014-09-19  6:32 ` [U-Boot] " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5416BA86.50306@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox