[U-Boot] [PATCH] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

[U-Boot] [PATCH] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

[Boris BREZILLON]

Disable subpage write when using PMECC to prevent buggy partial page write.

This fix has been taken from linux sources (see commit
90445ff6241e2a13445310803e2efa606c61f276)

Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
---
Hi,

Here is a link to the linux commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276

Best Regards,

Boris

 drivers/mtd/nand/atmel_nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index e73834d..ee67662 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -881,6 +881,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
 		return -ENOMEM;
 	}
 
+	nand->options |= NAND_NO_SUBPAGE_WRITE;
 	nand->ecc.read_page = atmel_nand_pmecc_read_page;
 	nand->ecc.write_page = atmel_nand_pmecc_write_page;
 	nand->ecc.strength = cap;
-- 
1.9.1

[U-Boot] [PATCH] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

[Josh Wu]

Hi, Boris

On 9/2/2014 4:23 PM, Boris BREZILLON wrote:
> Disable subpage write when using PMECC to prevent buggy partial page write.
>
> This fix has been taken from linux sources (see commit
> 90445ff6241e2a13445310803e2efa606c61f276)
>
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

Sorry for the later reply. And
Acked-by: Josh Wu <josh.wu@atmel.com>

Best Regards,
Josh Wu

> ---
> Hi,
>
> Here is a link to the linux commit:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276
>
> Best Regards,
>
> Boris
>
>   drivers/mtd/nand/atmel_nand.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index e73834d..ee67662 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -881,6 +881,7 @@ static int atmel_pmecc_nand_init_params(struct nand_chip *nand,
>   		return -ENOMEM;
>   	}
>   
> +	nand->options |= NAND_NO_SUBPAGE_WRITE;
>   	nand->ecc.read_page = atmel_nand_pmecc_read_page;
>   	nand->ecc.write_page = atmel_nand_pmecc_write_page;
>   	nand->ecc.strength = cap;

[U-Boot] mtd: atmel_nand: Disable subpage NAND write when using Atmel PMECC

[Andreas Bießmann]

Dear Boris BREZILLON,

Boris BREZILLON <boris.brezillon@free-electrons.com> writes:
>Disable subpage write when using PMECC to prevent buggy partial page write.
>
>This fix has been taken from linux sources (see commit
>90445ff6241e2a13445310803e2efa606c61f276)
>
>Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
>Acked-by: Josh Wu <josh.wu@atmel.com>
>---
>Hi,
>
>Here is a link to the linux commit:
>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/nand/atmel_nand.c?id=90445ff6241e2a13445310803e2efa606c61f276
>
>Best Regards,
>
>Boris
>
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bie?mann