* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
@ 2014-08-22 21:04 Stephen Warren
2014-09-17 16:16 ` Stephen Warren
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Warren @ 2014-08-22 21:04 UTC (permalink / raw)
To: u-boot
From: Stephen Warren <swarren@nvidia.com>
This pinmux tables currently omit any configuration for PCIe clk_req,
wake, and rst pins, which in turn causes intermittent failures in
U-Boot's PCIe support. Import an updated version of the pinmux tables
which rectifies this.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h b/board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h
index d338818a64eb..de4eb355982c 100644
--- a/board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h
+++ b/board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h
@@ -283,6 +283,11 @@ static const struct pmux_pingrp_config jetson_tk1_pingrps[] = {
PINCFG(PCC2, DEFAULT, DOWN, NORMAL, INPUT, DEFAULT, DEFAULT),
PINCFG(SDMMC4_CLK_PCC4, SDMMC4, NORMAL, NORMAL, INPUT, DEFAULT, DEFAULT),
PINCFG(CLK2_REQ_PCC5, DEFAULT, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
+ PINCFG(PEX_L0_RST_N_PDD1, PE0, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
+ PINCFG(PEX_L0_CLKREQ_N_PDD2, PE0, UP, NORMAL, INPUT, DEFAULT, DEFAULT),
+ PINCFG(PEX_WAKE_N_PDD3, PE, UP, NORMAL, INPUT, DEFAULT, DEFAULT),
+ PINCFG(PEX_L1_RST_N_PDD5, PE1, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
+ PINCFG(PEX_L1_CLKREQ_N_PDD6, PE1, UP, NORMAL, INPUT, DEFAULT, DEFAULT),
PINCFG(CLK3_OUT_PEE0, EXTPERIPH3, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
PINCFG(CLK3_REQ_PEE1, DEFAULT, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
PINCFG(DAP_MCLK1_REQ_PEE2, SATA, NORMAL, NORMAL, OUTPUT, DEFAULT, DEFAULT),
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-08-22 21:04 [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables Stephen Warren
@ 2014-09-17 16:16 ` Stephen Warren
2014-09-17 16:19 ` Tom Warren
2014-10-14 15:24 ` Stephen Warren
0 siblings, 2 replies; 14+ messages in thread
From: Stephen Warren @ 2014-09-17 16:16 UTC (permalink / raw)
To: u-boot
On 08/22/2014 03:04 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> This pinmux tables currently omit any configuration for PCIe clk_req,
> wake, and rst pins, which in turn causes intermittent failures in
> U-Boot's PCIe support. Import an updated version of the pinmux tables
> which rectifies this.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Could this please make it into the imminent v2014.10 release?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-09-17 16:16 ` Stephen Warren
@ 2014-09-17 16:19 ` Tom Warren
2014-10-14 15:24 ` Stephen Warren
1 sibling, 0 replies; 14+ messages in thread
From: Tom Warren @ 2014-09-17 16:19 UTC (permalink / raw)
To: u-boot
I take a look today.
> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Wednesday, September 17, 2014 9:17 AM
> To: Tom Warren
> Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Thierry Reding;
> Tom Rini
> Subject: Re: [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the
> Jetson TK1 pinmux tables
>
> On 08/22/2014 03:04 PM, Stephen Warren wrote:
> > From: Stephen Warren <swarren@nvidia.com>
> >
> > This pinmux tables currently omit any configuration for PCIe clk_req,
> > wake, and rst pins, which in turn causes intermittent failures in
> > U-Boot's PCIe support. Import an updated version of the pinmux tables
> > which rectifies this.
> >
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Could this please make it into the imminent v2014.10 release?
--
nvpublic
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-09-17 16:16 ` Stephen Warren
2014-09-17 16:19 ` Tom Warren
@ 2014-10-14 15:24 ` Stephen Warren
2014-10-14 18:05 ` Tom Warren
1 sibling, 1 reply; 14+ messages in thread
From: Stephen Warren @ 2014-10-14 15:24 UTC (permalink / raw)
To: u-boot
On 09/17/2014 10:16 AM, Stephen Warren wrote:
> On 08/22/2014 03:04 PM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> This pinmux tables currently omit any configuration for PCIe clk_req,
>> wake, and rst pins, which in turn causes intermittent failures in
>> U-Boot's PCIe support. Import an updated version of the pinmux tables
>> which rectifies this.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Could this please make it into the imminent v2014.10 release?
I see this in u-boot-tegra/master, but it doesn't seem to be in
u-boot-arm/master or u-boot/master.
Did a pull request get sent for this commit? I'd really like to see this
bugfix get applied to the main U-Boot repo ASAP...
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-14 15:24 ` Stephen Warren
@ 2014-10-14 18:05 ` Tom Warren
2014-10-14 22:28 ` Albert ARIBAUD
0 siblings, 1 reply; 14+ messages in thread
From: Tom Warren @ 2014-10-14 18:05 UTC (permalink / raw)
To: u-boot
My gmail account has been in flux for a few weeks, so I can't say for sure whether I sent a PR or not.
I'll resend one today to Albert.
Tom
> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Tuesday, October 14, 2014 8:25 AM
> To: Tom Warren; Tom Rini; albert.u.boot at aribaud.net
> Cc: u-boot at lists.denx.de; Simon Glass; Stephen Warren; Thierry Reding
> Subject: Re: [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the
> Jetson TK1 pinmux tables
>
> On 09/17/2014 10:16 AM, Stephen Warren wrote:
> > On 08/22/2014 03:04 PM, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> This pinmux tables currently omit any configuration for PCIe clk_req,
> >> wake, and rst pins, which in turn causes intermittent failures in
> >> U-Boot's PCIe support. Import an updated version of the pinmux tables
> >> which rectifies this.
> >>
> >> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >
> > Could this please make it into the imminent v2014.10 release?
>
> I see this in u-boot-tegra/master, but it doesn't seem to be in u-boot-
> arm/master or u-boot/master.
>
> Did a pull request get sent for this commit? I'd really like to see this bugfix get
> applied to the main U-Boot repo ASAP...
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-14 18:05 ` Tom Warren
@ 2014-10-14 22:28 ` Albert ARIBAUD
2014-10-14 23:14 ` Tom Warren
0 siblings, 1 reply; 14+ messages in thread
From: Albert ARIBAUD @ 2014-10-14 22:28 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Tue, 14 Oct 2014 18:05:40 +0000, Tom Warren <TWarren@nvidia.com>
wrote:
> My gmail account has been in flux for a few weeks, so I can't say for sure whether I sent a PR or not.
I've gone through the U-Boot archives, and the last tegra PR sent was
on aug 20, applied aug 29.
> I'll resend one today to Albert.
I'll make sue to apply it as soon as I get it in my inbox.
> Tom
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-14 22:28 ` Albert ARIBAUD
@ 2014-10-14 23:14 ` Tom Warren
2014-10-15 11:43 ` Albert ARIBAUD
0 siblings, 1 reply; 14+ messages in thread
From: Tom Warren @ 2014-10-14 23:14 UTC (permalink / raw)
To: u-boot
Albert,
Please pull u-boot-tegra/master into ARM/master. Thanks!
The following changes since commit a7f99bf139b3aaa0d5494693fd0395084355e41a:
arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39 +0200)
are available in the git repository at:
git://git.denx.de/u-boot-tegra.git master
for you to fetch changes up to 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04 -0700)
----------------------------------------------------------------
Marcel Ziswiler (1):
arm: tegra: initial support for apalis t30
Stephen Warren (1):
ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
arch/arm/cpu/armv7/tegra30/Kconfig | 4 +
arch/arm/dts/Makefile | 1 +
arch/arm/dts/tegra30-apalis.dts | 300 ++++++++++++++++++
arch/arm/include/asm/mach-types.h | 13 +
board/nvidia/jetson-tk1/pinmux-config-jetson-tk1.h | 5 +
board/toradex/apalis_t30/Kconfig | 15 +
board/toradex/apalis_t30/MAINTAINERS | 7 +
board/toradex/apalis_t30/Makefile | 6 +
board/toradex/apalis_t30/apalis_t30.c | 92 ++++++
.../toradex/apalis_t30/pinmux-config-apalis_t30.h | 347 +++++++++++++++++++++
configs/apalis_t30_defconfig | 4 +
include/configs/apalis_t30.h | 80 +++++
12 files changed, 874 insertions(+)
create mode 100644 arch/arm/dts/tegra30-apalis.dts
create mode 100644 board/toradex/apalis_t30/Kconfig
create mode 100644 board/toradex/apalis_t30/MAINTAINERS
create mode 100644 board/toradex/apalis_t30/Makefile
create mode 100644 board/toradex/apalis_t30/apalis_t30.c
create mode 100644 board/toradex/apalis_t30/pinmux-config-apalis_t30.h
create mode 100644 configs/apalis_t30_defconfig
create mode 100644 include/configs/apalis_t30.h
--
nvpublic
> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
> Sent: Tuesday, October 14, 2014 3:28 PM
> To: Tom Warren
> Cc: Stephen Warren; Tom Rini; u-boot at lists.denx.de; Simon Glass; Stephen
> Warren; Thierry Reding
> Subject: Re: [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the
> Jetson TK1 pinmux tables
>
> Hi Tom,
>
> On Tue, 14 Oct 2014 18:05:40 +0000, Tom Warren <TWarren@nvidia.com>
> wrote:
>
> > My gmail account has been in flux for a few weeks, so I can't say for sure
> whether I sent a PR or not.
>
> I've gone through the U-Boot archives, and the last tegra PR sent was on aug
> 20, applied aug 29.
>
> > I'll resend one today to Albert.
>
> I'll make sue to apply it as soon as I get it in my inbox.
>
> > Tom
>
> Amicalement,
> --
> Albert.
^ permalink raw reply [flat|nested] 14+ messages in thread* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-14 23:14 ` Tom Warren
@ 2014-10-15 11:43 ` Albert ARIBAUD
2014-10-15 15:34 ` Stephen Warren
0 siblings, 1 reply; 14+ messages in thread
From: Albert ARIBAUD @ 2014-10-15 11:43 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
wrote:
> Albert,
>
> Please pull u-boot-tegra/master into ARM/master. Thanks!
>
> The following changes since commit a7f99bf139b3aaa0d5494693fd0395084355e41a:
>
> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39 +0200)
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-tegra.git master
>
> for you to fetch changes up to 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
>
> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04 -0700)
>
> ----------------------------------------------------------------
> Marcel Ziswiler (1):
> arm: tegra: initial support for apalis t30
>
> Stephen Warren (1):
> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
This new board fails when I merge this branch to u-boot-arm/master,
with the following diagnostics:
include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
redefined [enabled by default]
In file included
from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
from <command-line>:0:
include/generated/autoconf.h:8:0: note: this is the location of the
previous definition
(actually, there is a lot of these, for various config options)
Device Tree Source is not correctly specified.
Please define 'CONFIG_DEFAULT_DEVICE_TREE'
or build with 'DEVICE_TREE=<device_tree>' argument
(This one is fatal even though it does not explicitly state "error:")
This failure does not happen on the tegra branch; it is obviously due
to the Kbuild stuff.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 14+ messages in thread* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 11:43 ` Albert ARIBAUD
@ 2014-10-15 15:34 ` Stephen Warren
2014-10-15 15:39 ` Albert ARIBAUD
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Warren @ 2014-10-15 15:34 UTC (permalink / raw)
To: u-boot
On 10/15/2014 05:43 AM, Albert ARIBAUD wrote:
> Hi Tom,
>
> On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
> wrote:
>
>> Albert,
>>
>> Please pull u-boot-tegra/master into ARM/master. Thanks!
>>
>> The following changes since commit a7f99bf139b3aaa0d5494693fd0395084355e41a:
>>
>> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39 +0200)
>>
>> are available in the git repository at:
>>
>> git://git.denx.de/u-boot-tegra.git master
>>
>> for you to fetch changes up to 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
>>
>> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04 -0700)
>>
>> ----------------------------------------------------------------
>> Marcel Ziswiler (1):
>> arm: tegra: initial support for apalis t30
>>
>> Stephen Warren (1):
>> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
>
> This new board fails when I merge this branch to u-boot-arm/master,
> with the following diagnostics:
>
> include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
> redefined [enabled by default]
> In file included
> from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
> from <command-line>:0:
> include/generated/autoconf.h:8:0: note: this is the location of the
> previous definition
>
> (actually, there is a lot of these, for various config options)
>
> Device Tree Source is not correctly specified.
> Please define 'CONFIG_DEFAULT_DEVICE_TREE'
> or build with 'DEVICE_TREE=<device_tree>' argument
>
> (This one is fatal even though it does not explicitly state "error:")
>
> This failure does not happen on the tegra branch; it is obviously due
> to the Kbuild stuff.
This issue should be fixed by:
https://patchwork.ozlabs.org/patch/398793/
[U-Boot] tegra: apalis_t30: master revamp
However, I would assert that at this point during the release cycle, we
probably shouldn't be adding new boards/features, but just fixing bugs.
Perhaps we should drop the Apalis patch completely and re-apply it once
the release is out?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 15:34 ` Stephen Warren
@ 2014-10-15 15:39 ` Albert ARIBAUD
2014-10-15 15:59 ` Tom Warren
2014-10-15 16:38 ` Stephen Warren
0 siblings, 2 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2014-10-15 15:39 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On Wed, 15 Oct 2014 09:34:49 -0600, Stephen Warren
<swarren@wwwdotorg.org> wrote:
> On 10/15/2014 05:43 AM, Albert ARIBAUD wrote:
> > Hi Tom,
> >
> > On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
> > wrote:
> >
> >> Albert,
> >>
> >> Please pull u-boot-tegra/master into ARM/master. Thanks!
> >>
> >> The following changes since commit a7f99bf139b3aaa0d5494693fd0395084355e41a:
> >>
> >> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39 +0200)
> >>
> >> are available in the git repository at:
> >>
> >> git://git.denx.de/u-boot-tegra.git master
> >>
> >> for you to fetch changes up to 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
> >>
> >> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04 -0700)
> >>
> >> ----------------------------------------------------------------
> >> Marcel Ziswiler (1):
> >> arm: tegra: initial support for apalis t30
> >>
> >> Stephen Warren (1):
> >> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
> >
> > This new board fails when I merge this branch to u-boot-arm/master,
> > with the following diagnostics:
> >
> > include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
> > redefined [enabled by default]
> > In file included
> > from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
> > from <command-line>:0:
> > include/generated/autoconf.h:8:0: note: this is the location of the
> > previous definition
> >
> > (actually, there is a lot of these, for various config options)
> >
> > Device Tree Source is not correctly specified.
> > Please define 'CONFIG_DEFAULT_DEVICE_TREE'
> > or build with 'DEVICE_TREE=<device_tree>' argument
> >
> > (This one is fatal even though it does not explicitly state "error:")
> >
> > This failure does not happen on the tegra branch; it is obviously due
> > to the Kbuild stuff.
>
> This issue should be fixed by:
>
> https://patchwork.ozlabs.org/patch/398793/
> [U-Boot] tegra: apalis_t30: master revamp
>
> However, I would assert that at this point during the release cycle, we
> probably shouldn't be adding new boards/features, but just fixing bugs.
> Perhaps we should drop the Apalis patch completely and re-apply it once
> the release is out?
Ok. Should I still apply the TK1 pinmux patch, or should I consider the
whole PR to be for -next?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 15:39 ` Albert ARIBAUD
@ 2014-10-15 15:59 ` Tom Warren
2014-10-15 16:34 ` Albert ARIBAUD
2014-10-15 16:38 ` Stephen Warren
1 sibling, 1 reply; 14+ messages in thread
From: Tom Warren @ 2014-10-15 15:59 UTC (permalink / raw)
To: u-boot
Albert,
I did a Makeall -s tegra before sending the PR (as I always do), and I saw no failures. But I haven't rebased against ARM master in a few weeks.
I think the Jetson TK1 change is still valid and should go in.
Thanks,
Tom
> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
> Sent: Wednesday, October 15, 2014 8:40 AM
> To: Stephen Warren
> Cc: Tom Warren; u-boot at lists.denx.de; Simon Glass; Tom Rini; Stephen
> Warren; Thierry Reding
> Subject: Re: [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the
> Jetson TK1 pinmux tables
>
> Hi Stephen,
>
> On Wed, 15 Oct 2014 09:34:49 -0600, Stephen Warren
> <swarren@wwwdotorg.org> wrote:
>
> > On 10/15/2014 05:43 AM, Albert ARIBAUD wrote:
> > > Hi Tom,
> > >
> > > On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
> > > wrote:
> > >
> > >> Albert,
> > >>
> > >> Please pull u-boot-tegra/master into ARM/master. Thanks!
> > >>
> > >> The following changes since commit
> a7f99bf139b3aaa0d5494693fd0395084355e41a:
> > >>
> > >> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11
> > >> 18:04:39 +0200)
> > >>
> > >> are available in the git repository at:
> > >>
> > >> git://git.denx.de/u-boot-tegra.git master
> > >>
> > >> for you to fetch changes up to
> 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
> > >>
> > >> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04
> > >> -0700)
> > >>
> > >> ----------------------------------------------------------------
> > >> Marcel Ziswiler (1):
> > >> arm: tegra: initial support for apalis t30
> > >>
> > >> Stephen Warren (1):
> > >> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux
> > >> tables
> > >
> > > This new board fails when I merge this branch to u-boot-arm/master,
> > > with the following diagnostics:
> > >
> > > include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
> > > redefined [enabled by default]
> > > In file included
> > > from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
> > > from <command-line>:0:
> > > include/generated/autoconf.h:8:0: note: this is the location of the
> > > previous definition
> > >
> > > (actually, there is a lot of these, for various config options)
> > >
> > > Device Tree Source is not correctly specified.
> > > Please define 'CONFIG_DEFAULT_DEVICE_TREE'
> > > or build with 'DEVICE_TREE=<device_tree>' argument
> > >
> > > (This one is fatal even though it does not explicitly state
> > > "error:")
> > >
> > > This failure does not happen on the tegra branch; it is obviously
> > > due to the Kbuild stuff.
> >
> > This issue should be fixed by:
> >
> > https://patchwork.ozlabs.org/patch/398793/
> > [U-Boot] tegra: apalis_t30: master revamp
> >
> > However, I would assert that at this point during the release cycle,
> > we probably shouldn't be adding new boards/features, but just fixing bugs.
> > Perhaps we should drop the Apalis patch completely and re-apply it
> > once the release is out?
>
> Ok. Should I still apply the TK1 pinmux patch, or should I consider the whole
> PR to be for -next?
>
> Amicalement,
> --
> Albert.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 15:59 ` Tom Warren
@ 2014-10-15 16:34 ` Albert ARIBAUD
0 siblings, 0 replies; 14+ messages in thread
From: Albert ARIBAUD @ 2014-10-15 16:34 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Wed, 15 Oct 2014 15:59:44 +0000, Tom Warren <TWarren@nvidia.com>
wrote:
> Albert,
>
> I did a Makeall -s tegra before sending the PR (as I always do), and I saw no failures. But I haven't rebased against ARM master in a few weeks.
>
> I think the Jetson TK1 change is still valid and should go in.
Ok. Seeing as this is a single patch to pick and board-, not arm-,
specific, maybe Tom (Rini, promoted to To:) can pick it up directly
instead of going through an ARM PR?
> Thanks,
>
> Tom
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 15:39 ` Albert ARIBAUD
2014-10-15 15:59 ` Tom Warren
@ 2014-10-15 16:38 ` Stephen Warren
2014-10-15 16:41 ` Simon Glass
1 sibling, 1 reply; 14+ messages in thread
From: Stephen Warren @ 2014-10-15 16:38 UTC (permalink / raw)
To: u-boot
On 10/15/2014 09:39 AM, Albert ARIBAUD wrote:
> Hi Stephen,
>
> On Wed, 15 Oct 2014 09:34:49 -0600, Stephen Warren
> <swarren@wwwdotorg.org> wrote:
>
>> On 10/15/2014 05:43 AM, Albert ARIBAUD wrote:
>>> Hi Tom,
>>>
>>> On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
>>> wrote:
>>>
>>>> Albert,
>>>>
>>>> Please pull u-boot-tegra/master into ARM/master. Thanks!
>>>>
>>>> The following changes since commit a7f99bf139b3aaa0d5494693fd0395084355e41a:
>>>>
>>>> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39 +0200)
>>>>
>>>> are available in the git repository at:
>>>>
>>>> git://git.denx.de/u-boot-tegra.git master
>>>>
>>>> for you to fetch changes up to 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
>>>>
>>>> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04 -0700)
>>>>
>>>> ----------------------------------------------------------------
>>>> Marcel Ziswiler (1):
>>>> arm: tegra: initial support for apalis t30
>>>>
>>>> Stephen Warren (1):
>>>> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
>>>
>>> This new board fails when I merge this branch to u-boot-arm/master,
>>> with the following diagnostics:
>>>
>>> include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
>>> redefined [enabled by default]
>>> In file included
>>> from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
>>> from <command-line>:0:
>>> include/generated/autoconf.h:8:0: note: this is the location of the
>>> previous definition
>>>
>>> (actually, there is a lot of these, for various config options)
>>>
>>> Device Tree Source is not correctly specified.
>>> Please define 'CONFIG_DEFAULT_DEVICE_TREE'
>>> or build with 'DEVICE_TREE=<device_tree>' argument
>>>
>>> (This one is fatal even though it does not explicitly state "error:")
>>>
>>> This failure does not happen on the tegra branch; it is obviously due
>>> to the Kbuild stuff.
>>
>> This issue should be fixed by:
>>
>> https://patchwork.ozlabs.org/patch/398793/
>> [U-Boot] tegra: apalis_t30: master revamp
>>
>> However, I would assert that at this point during the release cycle, we
>> probably shouldn't be adding new boards/features, but just fixing bugs.
>> Perhaps we should drop the Apalis patch completely and re-apply it once
>> the release is out?
>
> Ok. Should I still apply the TK1 pinmux patch, or should I consider the
> whole PR to be for -next?
I consider the Jetson TK1 pinmux patch a bug-fix; it adds entries that
always should have been there.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
2014-10-15 16:38 ` Stephen Warren
@ 2014-10-15 16:41 ` Simon Glass
0 siblings, 0 replies; 14+ messages in thread
From: Simon Glass @ 2014-10-15 16:41 UTC (permalink / raw)
To: u-boot
Hi,
On 15 October 2014 18:38, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 10/15/2014 09:39 AM, Albert ARIBAUD wrote:
>>
>> Hi Stephen,
>>
>> On Wed, 15 Oct 2014 09:34:49 -0600, Stephen Warren
>> <swarren@wwwdotorg.org> wrote:
>>
>>> On 10/15/2014 05:43 AM, Albert ARIBAUD wrote:
>>>>
>>>> Hi Tom,
>>>>
>>>> On Tue, 14 Oct 2014 23:14:24 +0000, Tom Warren <TWarren@nvidia.com>
>>>> wrote:
>>>>
>>>>> Albert,
>>>>>
>>>>> Please pull u-boot-tegra/master into ARM/master. Thanks!
>>>>>
>>>>> The following changes since commit
>>>>> a7f99bf139b3aaa0d5494693fd0395084355e41a:
>>>>>
>>>>> arm: Fix _start for CONFIG_SYS_DV_NOR_BOOT_CFG (2014-09-11 18:04:39
>>>>> +0200)
>>>>>
>>>>> are available in the git repository at:
>>>>>
>>>>> git://git.denx.de/u-boot-tegra.git master
>>>>>
>>>>> for you to fetch changes up to
>>>>> 90a565acf3a18c61170ec0e0b2046c98cb7ecc85:
>>>>>
>>>>> arm: tegra: initial support for apalis t30 (2014-09-17 11:15:04
>>>>> -0700)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Marcel Ziswiler (1):
>>>>> arm: tegra: initial support for apalis t30
>>>>>
>>>>> Stephen Warren (1):
>>>>> ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux
>>>>> tables
>>>>
>>>>
>>>> This new board fails when I merge this branch to u-boot-arm/master,
>>>> with the following diagnostics:
>>>>
>>>> include/configs/apalis_t30.h:17:0: warning: "CONFIG_OF_SEPARATE"
>>>> redefined [enabled by default]
>>>> In file included
>>>> from /home/albert.u.boot/src/u-boot-arm/include/linux/kconfig.h:4:0,
>>>> from <command-line>:0:
>>>> include/generated/autoconf.h:8:0: note: this is the location of the
>>>> previous definition
>>>>
>>>> (actually, there is a lot of these, for various config options)
>>>>
>>>> Device Tree Source is not correctly specified.
>>>> Please define 'CONFIG_DEFAULT_DEVICE_TREE'
>>>> or build with 'DEVICE_TREE=<device_tree>' argument
>>>>
>>>> (This one is fatal even though it does not explicitly state "error:")
>>>>
>>>> This failure does not happen on the tegra branch; it is obviously due
>>>> to the Kbuild stuff.
>>>
>>>
>>> This issue should be fixed by:
>>>
>>> https://patchwork.ozlabs.org/patch/398793/
>>> [U-Boot] tegra: apalis_t30: master revamp
>>>
>>> However, I would assert that at this point during the release cycle, we
>>> probably shouldn't be adding new boards/features, but just fixing bugs.
>>> Perhaps we should drop the Apalis patch completely and re-apply it once
>>> the release is out?
>>
>>
>> Ok. Should I still apply the TK1 pinmux patch, or should I consider the
>> whole PR to be for -next?
>
>
> I consider the Jetson TK1 pinmux patch a bug-fix; it adds entries that
> always should have been there.
BTW the release has already gone out. Also what is the status of the
Norrin patch? Will that go into Tegra soon?
Regards,
Simon
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-10-15 16:41 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 21:04 [U-Boot] [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables Stephen Warren
2014-09-17 16:16 ` Stephen Warren
2014-09-17 16:19 ` Tom Warren
2014-10-14 15:24 ` Stephen Warren
2014-10-14 18:05 ` Tom Warren
2014-10-14 22:28 ` Albert ARIBAUD
2014-10-14 23:14 ` Tom Warren
2014-10-15 11:43 ` Albert ARIBAUD
2014-10-15 15:34 ` Stephen Warren
2014-10-15 15:39 ` Albert ARIBAUD
2014-10-15 15:59 ` Tom Warren
2014-10-15 16:34 ` Albert ARIBAUD
2014-10-15 16:38 ` Stephen Warren
2014-10-15 16:41 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox