From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/11] dm: imx: Use gpio_request() to request GPIOs
Date: Thu, 18 Sep 2014 10:23:44 +0300 [thread overview]
Message-ID: <541A8880.2090305@compulab.co.il> (raw)
In-Reply-To: <CAPnjgZ2zd4_teZ17L=ROq0bM3HGE_nF6NnmReEWk1j=2QmWh3g@mail.gmail.com>
On 09/17/14 17:34, Simon Glass wrote:
> Hi Igor,
>
> On 17 September 2014 08:31, Igor Grinberg <grinberg at compulab.co.il <mailto:grinberg@compulab.co.il>> wrote:
>
> On 09/17/14 17:00, Simon Glass wrote:
> > Hi Igor,
> >
> > On 17 September 2014 06:13, Igor Grinberg <grinberg at compulab.co.il <mailto:grinberg@compulab.co.il> <mailto:grinberg at compulab.co.il <mailto:grinberg@compulab.co.il>>> wrote:
> >
> > Hi Simon,
> >
> > On 09/17/14 06:51, Simon Glass wrote:
> > > GPIOs should be requested before use. Without this, driver model will not
> > > permit the GPIO to be used.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org <mailto:sjg@chromium.org> <mailto:sjg at chromium.org <mailto:sjg@chromium.org>>>
> > > ---
> > >
> > > Changes in v2:
> > > - Check return values of gpio_request()
> > >
> > > arch/arm/imx-common/i2c-mxv7.c | 24 ++++++++++++++++++++++++
> > > board/compulab/cm_fx6/cm_fx6.c | 15 +++++++++++++++
> > > board/compulab/cm_fx6/common.c | 7 +++++++
> > > 3 files changed, 46 insertions(+)
> > >
>
> [...]
>
> > > diff --git a/board/compulab/cm_fx6/common.c b/board/compulab/cm_fx6/common.c
> > > index 1f39679..e4d7e2e 100644
> > > --- a/board/compulab/cm_fx6/common.c
> > > +++ b/board/compulab/cm_fx6/common.c
> > > @@ -79,6 +79,13 @@ void cm_fx6_set_ecspi_iomux(void)
> > >
> > > int board_spi_cs_gpio(unsigned bus, unsigned cs)
> > > {
> > > +#ifndef CONFIG_SPL_BUILD
> > > + int ret;
> > > +
> > > + ret = gpio_request(CM_FX6_ECSPI_BUS0_CS0, "ecspi_bus0_cs0");
> > > + if (ret)
> > > + return ret;
> > > +#endif
> >
> > Is there a reason for excluding this request from spl builds?
> > We do build with CONFIG_SPL_GPIO_SUPPORT and we don't have a
> > problem with spl size.
> > So, if there is no strong reason to exclude it from spl build,
> > I'd like to remove the #ifndef.
> >
> >
> > It isn't supported by DM yet.
>
> AFAICS, gpio_request() is available for SPL.
> So in such case the non-DM version will be used and
> I can't see any problem with this (unless it does not work for some reason).
>
>
> I suggest that if you wanted the gpio_request() in the non-DM case you would already have added it?
I would thought so too... Unfortunately, it has slipped through...
>
> I would prefer not to have an #ifdef CONFIG_DM_GPIO here also. Can we revisit when DM supports SPL?
Yes, no problem.
--
Regards,
Igor.
next prev parent reply other threads:[~2014-09-18 7:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 3:51 [U-Boot] [PATCH v2 0/11] dm: imx: Add driver model support for GPIO and serial on cm_fx6 Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 01/11] dm: linker_lists: Add a way to declare multiple objects Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 02/11] dm: core: Allow a list of devices to be declared in one step Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 03/11] dm: core: Allow device_bind() to used without CONFIG_OF_CONTROL Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 04/11] initcall: Display error number when an error occurs Simon Glass
2014-09-17 7:40 ` Igor Grinberg
2014-09-17 3:51 ` [U-Boot] [PATCH v2 05/11] dm: serial: Don't require device tree to configure a console Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 06/11] dm: serial: Put common code into separate functions Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 07/11] dm: imx: Add error checking to setup_i2c() Simon Glass
2014-09-17 8:37 ` Igor Grinberg
2014-09-17 13:56 ` Simon Glass
2014-09-17 14:16 ` Igor Grinberg
2014-09-17 3:51 ` [U-Boot] [PATCH v2 08/11] dm: imx: Use gpio_request() to request GPIOs Simon Glass
2014-09-17 12:13 ` Igor Grinberg
2014-09-17 14:00 ` Simon Glass
2014-09-17 14:31 ` Igor Grinberg
2014-09-17 14:34 ` Simon Glass
2014-09-18 7:23 ` Igor Grinberg [this message]
2014-09-17 3:51 ` [U-Boot] [PATCH v2 09/11] dm: imx: gpio: Support driver model in MXC gpio driver Simon Glass
2014-09-17 13:00 ` Igor Grinberg
2014-09-17 14:03 ` Simon Glass
2014-09-17 14:34 ` Igor Grinberg
2014-09-17 3:51 ` [U-Boot] [PATCH v2 10/11] dm: imx: serial: Support driver model in the MXC serial driver Simon Glass
2014-09-17 3:51 ` [U-Boot] [PATCH v2 11/11] dm: imx: Move cm_fx6 to use driver model for serial and GPIO Simon Glass
2014-09-17 13:07 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A8880.2090305@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox