* [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus")
@ 2014-09-18 17:21 Stephen Warren
2014-09-19 6:30 ` Igor Grinberg
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Warren @ 2014-09-18 17:21 UTC (permalink / raw)
To: u-boot
After commit 52658fda7abc ("compulab: eeprom: add support for defining
eeprom i2c bus"), the trimslice board fails to build with:
.../board/compulab/common/eeprom.c: In function ?cl_eeprom_read?:
.../board/compulab/common/eeprom.c:37:24: error:
?CONFIG_SYS_I2C_EEPROM_BUS? undeclared (first use in this function)
.../board/compulab/common/eeprom.c:37:24: note: each undeclared
identifier is reported only once for each function it appears in
I have no idea if this EEPROM code should even run on TrimSlice or not.
Can you take a look at the correct fix?
^ permalink raw reply [flat|nested] 2+ messages in thread* [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus")
2014-09-18 17:21 [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus") Stephen Warren
@ 2014-09-19 6:30 ` Igor Grinberg
0 siblings, 0 replies; 2+ messages in thread
From: Igor Grinberg @ 2014-09-19 6:30 UTC (permalink / raw)
To: u-boot
Hi Stephen,
On 09/18/14 20:21, Stephen Warren wrote:
> After commit 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus"), the trimslice board fails to build with:
>
> .../board/compulab/common/eeprom.c: In function ?cl_eeprom_read?:
> .../board/compulab/common/eeprom.c:37:24: error: ?CONFIG_SYS_I2C_EEPROM_BUS? undeclared (first use in this function)
> .../board/compulab/common/eeprom.c:37:24: note: each undeclared identifier is reported only once for each function it appears in
>
> I have no idea if this EEPROM code should even run on TrimSlice or not. Can you take a look at the correct fix?
We have already submitted a temporary fix, see [1].
The intend is to switch to Kconfig for all CompuLab boards
and that will bring the proper fix for the problem.
After this, the temporary fixes can be removed.
[1] https://patchwork.ozlabs.org/patch/390381/
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-19 6:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-18 17:21 [U-Boot] compulab trimslice build error due to 52658fda7abc ("compulab: eeprom: add support for defining eeprom i2c bus") Stephen Warren
2014-09-19 6:30 ` Igor Grinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox