* [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK
@ 2014-09-20 23:05 Fabio Estevam
2014-09-21 8:43 ` Igor Grinberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-09-20 23:05 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
We should not hardcode CONFIG_NETMASK in the config file.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/cm_fx6.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h
index 10d02b4..7cf241e 100644
--- a/include/configs/cm_fx6.h
+++ b/include/configs/cm_fx6.h
@@ -222,7 +222,6 @@
#define CONFIG_MII
#define CONFIG_ETHPRIME "FEC0"
#define CONFIG_ARP_TIMEOUT 200UL
-#define CONFIG_NETMASK 255.255.255.0
#define CONFIG_NET_RETRY_COUNT 5
/* USB */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK
2014-09-20 23:05 [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK Fabio Estevam
@ 2014-09-21 8:43 ` Igor Grinberg
2014-09-21 14:06 ` Nikita Kiryanov
2014-09-22 13:39 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Igor Grinberg @ 2014-09-21 8:43 UTC (permalink / raw)
To: u-boot
On 09/21/14 02:05, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should not hardcode CONFIG_NETMASK in the config file.
That is correct no doubts.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Cc'd Nikita,
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> include/configs/cm_fx6.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h
> index 10d02b4..7cf241e 100644
> --- a/include/configs/cm_fx6.h
> +++ b/include/configs/cm_fx6.h
> @@ -222,7 +222,6 @@
> #define CONFIG_MII
> #define CONFIG_ETHPRIME "FEC0"
> #define CONFIG_ARP_TIMEOUT 200UL
> -#define CONFIG_NETMASK 255.255.255.0
> #define CONFIG_NET_RETRY_COUNT 5
>
> /* USB */
>
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK
2014-09-20 23:05 [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK Fabio Estevam
2014-09-21 8:43 ` Igor Grinberg
@ 2014-09-21 14:06 ` Nikita Kiryanov
2014-09-22 13:39 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Nikita Kiryanov @ 2014-09-21 14:06 UTC (permalink / raw)
To: u-boot
Hi Fabio,
On 21/09/14 02:05, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should not hardcode CONFIG_NETMASK in the config file.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
--
Regards,
Nikita Kiryanov
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK
2014-09-20 23:05 [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK Fabio Estevam
2014-09-21 8:43 ` Igor Grinberg
2014-09-21 14:06 ` Nikita Kiryanov
@ 2014-09-22 13:39 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2014-09-22 13:39 UTC (permalink / raw)
To: u-boot
On 21/09/2014 01:05, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> We should not hardcode CONFIG_NETMASK in the config file.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-22 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-20 23:05 [U-Boot] [PATCH] cm_fx6: Remove CONFIG_NETMASK Fabio Estevam
2014-09-21 8:43 ` Igor Grinberg
2014-09-21 14:06 ` Nikita Kiryanov
2014-09-22 13:39 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox