* [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board
@ 2014-09-11 9:59 Guillaume GARDET
2014-09-14 18:53 ` Eric Nelson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guillaume GARDET @ 2014-09-11 9:59 UTC (permalink / raw)
To: u-boot
Sabrelite board has two solts: 0 is SD3 (bottom) slot and 1 is uSD4 (top) slot.
This patch makes use of both slots instead of only one.
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Eric Nelson <eric.nelson@boundarydevices.com>
---
include/configs/nitrogen6x.h | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index d4b0ac9..2a1eb3b 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -186,7 +186,7 @@
"fdt_addr=0x18000000\0" \
"boot_fdt=try\0" \
"ip_dyn=yes\0" \
- "mmcdev=0\0" \
+ "mmcdevs=0 1\0" \
"mmcpart=1\0" \
"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
"mmcargs=setenv bootargs console=${console},${baudrate} " \
@@ -238,16 +238,19 @@
"fi;\0"
#define CONFIG_BOOTCOMMAND \
- "mmc dev ${mmcdev}; if mmc rescan; then " \
- "if run loadbootscript; then " \
- "run bootscript; " \
- "else " \
- "if run loaduimage; then " \
- "run mmcboot; " \
- "else run netboot; " \
- "fi; " \
- "fi; " \
- "else run netboot; fi"
+ "for mmcdev in ${mmcdevs}; do " \
+ "mmc dev ${mmcdev}; " \
+ "if mmc rescan; then " \
+ "if run loadbootscript; then " \
+ "run bootscript; " \
+ "else " \
+ "if run loaduimage; then " \
+ "run mmcboot; " \
+ "fi; " \
+ "fi; " \
+ "fi; " \
+ "done; " \
+ "run netboot; "
#else
#define CONFIG_EXTRA_ENV_SETTINGS \
"console=ttymxc1\0" \
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board
2014-09-11 9:59 [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board Guillaume GARDET
@ 2014-09-14 18:53 ` Eric Nelson
2014-09-14 18:53 ` Eric Nelson
2014-09-22 13:53 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Eric Nelson @ 2014-09-14 18:53 UTC (permalink / raw)
To: u-boot
Hi Guillaume,
On 09/11/2014 02:59 AM, Guillaume GARDET wrote:
> Sabrelite board has two solts: 0 is SD3 (bottom) slot and 1 is uSD4 (top) slot.
> This patch makes use of both slots instead of only one.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Eric Nelson <eric.nelson@boundarydevices.com>
>
> ---
> include/configs/nitrogen6x.h | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index d4b0ac9..2a1eb3b 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -186,7 +186,7 @@
> "fdt_addr=0x18000000\0" \
> "boot_fdt=try\0" \
> "ip_dyn=yes\0" \
> - "mmcdev=0\0" \
> + "mmcdevs=0 1\0" \
> "mmcpart=1\0" \
> "mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
> "mmcargs=setenv bootargs console=${console},${baudrate} " \
> @@ -238,16 +238,19 @@
> "fi;\0"
>
> #define CONFIG_BOOTCOMMAND \
> - "mmc dev ${mmcdev}; if mmc rescan; then " \
> - "if run loadbootscript; then " \
> - "run bootscript; " \
> - "else " \
> - "if run loaduimage; then " \
> - "run mmcboot; " \
> - "else run netboot; " \
> - "fi; " \
> - "fi; " \
> - "else run netboot; fi"
If you add one more loop here, you'll end up with something
very close to the Nitrogen6x configuration!
> + "for mmcdev in ${mmcdevs}; do " \
> + "mmc dev ${mmcdev}; " \
> + "if mmc rescan; then " \
> + "if run loadbootscript; then " \
> + "run bootscript; " \
> + "else " \
> + "if run loaduimage; then " \
> + "run mmcboot; " \
> + "fi; " \
> + "fi; " \
> + "fi; " \
> + "done; " \
> + "run netboot; "
> #else
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "console=ttymxc1\0" \
>
Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board
2014-09-11 9:59 [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board Guillaume GARDET
2014-09-14 18:53 ` Eric Nelson
@ 2014-09-14 18:53 ` Eric Nelson
2014-09-22 13:53 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Eric Nelson @ 2014-09-14 18:53 UTC (permalink / raw)
To: u-boot
Hi Guillaume,
On 09/11/2014 02:59 AM, Guillaume GARDET wrote:
> Sabrelite board has two solts: 0 is SD3 (bottom) slot and 1 is uSD4 (top) slot.
> This patch makes use of both slots instead of only one.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Eric Nelson <eric.nelson@boundarydevices.com>
>
> ---
> include/configs/nitrogen6x.h | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index d4b0ac9..2a1eb3b 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -186,7 +186,7 @@
> "fdt_addr=0x18000000\0" \
> "boot_fdt=try\0" \
> "ip_dyn=yes\0" \
> - "mmcdev=0\0" \
> + "mmcdevs=0 1\0" \
> "mmcpart=1\0" \
> "mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
> "mmcargs=setenv bootargs console=${console},${baudrate} " \
> @@ -238,16 +238,19 @@
> "fi;\0"
>
> #define CONFIG_BOOTCOMMAND \
> - "mmc dev ${mmcdev}; if mmc rescan; then " \
> - "if run loadbootscript; then " \
> - "run bootscript; " \
> - "else " \
> - "if run loaduimage; then " \
> - "run mmcboot; " \
> - "else run netboot; " \
> - "fi; " \
> - "fi; " \
> - "else run netboot; fi"
If you add one more loop here, you can get SATA support
and end up with something very close to the Nitrogen6x
configuration!
> + "for mmcdev in ${mmcdevs}; do " \
> + "mmc dev ${mmcdev}; " \
> + "if mmc rescan; then " \
> + "if run loadbootscript; then " \
> + "run bootscript; " \
> + "else " \
> + "if run loaduimage; then " \
> + "run mmcboot; " \
> + "fi; " \
> + "fi; " \
> + "fi; " \
> + "done; " \
> + "run netboot; "
> #else
> #define CONFIG_EXTRA_ENV_SETTINGS \
> "console=ttymxc1\0" \
>
Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board
2014-09-11 9:59 [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board Guillaume GARDET
2014-09-14 18:53 ` Eric Nelson
2014-09-14 18:53 ` Eric Nelson
@ 2014-09-22 13:53 ` Stefano Babic
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2014-09-22 13:53 UTC (permalink / raw)
To: u-boot
On 11/09/2014 11:59, Guillaume GARDET wrote:
> Sabrelite board has two solts: 0 is SD3 (bottom) slot and 1 is uSD4 (top) slot.
> This patch makes use of both slots instead of only one.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Eric Nelson <eric.nelson@boundarydevices.com>
>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-22 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 9:59 [U-Boot] [PATCH] imx: nitrogen6x: Make use of both uSD and SD slots to load script or kernel on Sabrelite board Guillaume GARDET
2014-09-14 18:53 ` Eric Nelson
2014-09-14 18:53 ` Eric Nelson
2014-09-22 13:53 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox