From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
Date: Mon, 22 Sep 2014 09:14:58 -0700 [thread overview]
Message-ID: <54204B02.1010204@boundarydevices.com> (raw)
In-Reply-To: <20140922180055.5a60760d@amdc2363>
On 09/22/2014 09:00 AM, Lukasz Majewski wrote:
> Hi Marek,
>
>> On Saturday, September 20, 2014 at 02:06:46 AM, Eric Nelson wrote:
>>> Without this flag, tools like Alex Page's USB Image Tool
>>> won't see drives exposed over USB Gadget as removable,
>>> and won't allow access to them.
>>> http://www.alexpage.de/usb-image-tool/
>>>
>>> The code was pulled from the main-line kernel:
>>> drivers/usb/gadget/function/f_mass_storage.c
>>>
>>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>>
>> I'm OK with this. This should go to current release too. Lukasz, do
>> you agree ? Do you want to pick it + send me PR or shall I apply
>> directly ?
>
> Eric thanks for your patch.
>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Tested-by: Lukasz Majewski <l.majewski@samsung.com>
> Test HW (Trats - Exynos 4210)
>
> I've applied this patch to u-boot-dfu branch.
>
> I will send PR to Marek in a few days time.
>
Thanks Lukasz and Marek.
prev parent reply other threads:[~2014-09-22 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 0:06 [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN Eric Nelson
2014-09-20 7:01 ` Marek Vasut
2014-09-22 6:45 ` Lukasz Majewski
2014-09-22 16:00 ` Lukasz Majewski
2014-09-22 16:14 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54204B02.1010204@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox