From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikolay Dimitrov <picmaster+prvs=1343ce5590@mail.bg>
Date: Tue, 23 Sep 2014 00:38:19 +0300
Subject: [U-Boot] [PATCH V3] ARM: mx6: Add support for Kosagi Novena
In-Reply-To: <1411307086-12105-1-git-send-email-marex@denx.de>
References: <1411307086-12105-1-git-send-email-marex@denx.de>
Message-ID: <542096CB.8020209@mail.bg>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

I checked the I2C stuff, didn't saw any major issues. Here are a couple 
of comments for possible improvements:

On 09/21/2014 04:44 PM, Marek Vasut wrote:
> +/*
> + * I2C
> + */
> +/* I2C1, RAM */
> +struct i2c_pads_info i2c_pad_info0 = {
I can suggest to reword the comment as: "I2C1: DDR3 SO-DIMM RAM" or 
something similar, to avoid confusion with I2C RAM.

> +/* I2C2 Camera, MIPI */
> +static struct i2c_pads_info i2c_pad_info1 = {
I didn't found any MIPI camera on the schematic, so I think the comment 
is misleading. The connected devices on I2C2 are PMIC, HDMI DDC, FPGA, 
and only the PMIC could be useful for booting. So I can suggest to 
reword the comment like: "I2C2: PMIC".

> +/* I2C3, J15 - RGB connector */
> +static struct i2c_pads_info i2c_pad_info2 = {
I didn't found such connect J15 on my schematic (novena_pvt2.pdf). 
There's a connector JP10L, which is for the LCD panel. Again the comment 
could be reworded as: "I2C3: Utility EEPROM, LCD panel"

> +static void novena_spl_setup_iomux_i2c(void)
> +{
> +	setup_i2c(0, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info0);
> +	setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info1);
> +	setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2);
> +}
Is the I2C1 bus used anywhere? I found only usage of I2C2 for PMIC and 
I2C3 for Utility EEPROM reading.

> +/* I2C EEPROM */
> +#ifdef CONFIG_CMD_EEPROM
> +#define CONFIG_SYS_I2C_MULTI_EEPROMS
> +#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	2
> +#define CONFIG_SYS_SPD_BUS_NUM		2
> +#endif
I'm puzzled by the value of CONFIG_SYS_SPD_BUS_NUM - the SPD MEM is 
connected to I2C1, which should be bus 0, right?

These are only recommendations, please feel free to accept/reject them 
as you wish. The only reason why I suggest them is because usually the 
U-Boot source code is excellent documentation about the hardware boards, 
and any effort spent to clarify the peripherals and their usage will be 
greatly appreciated later by the U-Boot users.

Thanks again for your serious efforts to kick-off the Novena board support.

Kind regards,
Nikolay