[U-Boot] [PATCH fix for v2014.10 4/5] stdio: Add force parameter to stdio_deregister

Simon Glass
2014-10-09T17:03:02Z

Hi Tom,

On 9 October 2014 10:23, Tom Rini <trini@ti.com> wrote:
> On Thu, Oct 09, 2014 at 05:12:03PM +0200, Marek Vasut wrote:
>> On Thursday, October 09, 2014 at 08:18:14 AM, Simon Glass wrote:
>> > Hi,
>> >
>> > On 20 September 2014 08:54, Hans de Goede <hdegoede@redhat.com> wrote:
>> > > In some cases we really want to move forward with a deregister, add a
>> > > force parameter to allow this, and replace the dev with a nulldev in
>> > > this case.
>> > >
>> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> [...]
>>
>> > > diff --git a/drivers/serial/serial-uclass.c
>> > > b/drivers/serial/serial-uclass.c index d04104e..61cbdc6 100644
>> > > --- a/drivers/serial/serial-uclass.c
>> > > +++ b/drivers/serial/serial-uclass.c
>> > > @@ -197,7 +197,7 @@ static int serial_pre_remove(struct udevice *dev)
>> > >
>> > > #ifdef CONFIG_SYS_STDIO_DEREGISTER
>> > >
>> > > struct serial_dev_priv *upriv = dev->uclass_priv;
>> > >
>> > > - if (stdio_deregister_dev(upriv->sdev))
>> > > + if (stdio_deregister_dev(upriv->sdev), 0)
>> >
>> > That bracket seems to be in a strange place.
>>
>> Good find, thanks! I have two questions:
>> 1) How come I did not notice this and my build didn't spit?
>
> Because only sandbox uses this right now I think. But I'm unhappy that
> I can't seem to make repeated runs of:
> $ ./tools/buildman/buildman -b master -c 1 -ve -T 1 -j 9 \
> 'arc|blackfin|microblaze|m68k|nds32|sparc|x86|aarch64|sandbox|mips|avr32|arm|powerpc'
> $ ./tools/buildman/buildman -b master -c 1 -ve -T 1 -j 9 \
> 'arc|blackfin|microblaze|m68k|nds32|sparc|x86|aarch64|sandbox|mips|avr32|arm|powerpc' \
> -svel
>
> Show me just new problems from the last time I did it. I must be doing
> something wrong, Simon?

I don't really see anything obviously wrong. But I'm not sure what you
are expecting. This is going to just build the top commit in branch
master, and if the commit hash has changed it will remove any previous
results for that commit before starting the build. So you will always
get a full list of errors, not a delta from last time. If you want
that you could add a second commit with your fixes and not adjust the
first commit in the branch (and use -c2).

If you leave off '-b master -c1' it would have about the same effect,
assuming that you have 'master' checked out.

In the second line you are specifying -ve twice but that doesn't
matter. Why are you changing the thread/jobs defaults? Does that speed
it up? Also you don't need the quotes and the | between archs.

Also note there is --step to avoid building every commit. For example,
this will build the upstream commit and your branch's top commit
(only) assuming that master tracks upstream/master.

buildman -b master --step 0

Regards,
Simon