[U-Boot] [PATCH] i2c: mxs: Add I2C multibus support

Heiko Schocher
2014-09-24T05:18:43Z

Hello Marek,

Am 23.09.2014 16:30, schrieb Marek Vasut:
> On Tuesday, September 23, 2014 at 03:49:27 PM, Otavio Salvador wrote:
>> On Tue, Sep 23, 2014 at 8:48 AM, Heiko Schocher<hs@denx.de> wrote:
>>> Hello Marek,
>>>
>>> Am 23.09.2014 13:15, schrieb Marek Vasut:
>>>> The i.MX28 has two I2C IP blocks, but the MXS I2C driver is hard-coded
>>>> to use the I2C block 0 . Add multibus support so we can use both I2C
>>>> busses as seen fit.
>>>>
>>>> Signed-off-by: Marek Vasut<marex@denx.de>
>>>> Cc: Stefano Babic<sbabic@denx.de>
>>>> ---
>>>>
>>>> drivers/i2c/mxs_i2c.c | 47
>>>>
>>>> +++++++++++++++++++++++++++++++++++++----------
>>>>
>>>> include/configs/mxs.h | 1 +
>>>> 2 files changed, 38 insertions(+), 10 deletions(-)
>>>
>>> Sorry, I have to NACK this patch. Please convert the driver for using
>>> the CONFIG_SYS_I2C framework, see for example the drivers/i2c/mxc_i2c.c
>>> driver, thanks!
>>
>> I think the conversion could be a follow up patch, I see no good
>> reason to block this patch as is.
>
> I disagree with you. Accepting this patch as is would only hinder progress
> toward the conversion and would set a bad example further down the line, leading

Full ack ...

> only to more crap patches. Moreover, this is 2015.01 matter, so there is plenty
> of time for the rework to take place. Thus, I agree with Heiko.

Ok, perfect, thanks! And reworking this driver should be easy...

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany