public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block
Date: Wed, 24 Sep 2014 09:37:16 -0600	[thread overview]
Message-ID: <5422E52C.9070201@wwwdotorg.org> (raw)
In-Reply-To: <54223B0E.8060906@wwwdotorg.org>

On 09/23/2014 09:31 PM, Stephen Warren wrote:
> On 09/21/2014 07:13 AM, Marek Vasut wrote:
>> From: Oleksandr Tymoshenko <gonzo@bluezbox.com>
>>
>> This is the USB host controller used on the Altera SoCFPGA and Raspbery Pi.
>>
>> This code has three checkpatch warnings, but to make sure it stays at least
>> readable and clear, these are not fixed. These bugs are in the USB request
>> handling combinatorial logic, so any abstracting of those is out of question.
>>
>> Tested on DENX MCV (Altera SoCFPGA 5CSFXC6C6U23C8N) and RPi B+ (BCM2835).
>
> Patches 1, 3,
> Tested-by: Stephen Warren <swarren@nvidia.com>

Oops, I really should have used address swarren at wwwdotorg.org for both 
the Tested-by and Acked-by in this email, since I do RPi work on my own 
time.

> That said, I needed "ARM: rpi_b: query internal MAC address from
> firmware" to get the MAC address set up correctly. I obviously used that
> when testing. I guess I should send that patch:-)
>
> Patch 3,
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
>> Signed-off-by: Oleksandr Tymoshenko <gonzo@bluezbox.com>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>
> Given this patch has quite a few changes relative to what Oleksandr or I
> sent, it might be nice to include some notes in the commit description
> re: what you changed.
>
> [Marek, fiddled with the frob ...]
>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
>>   README                    |   3 +
>>   drivers/usb/host/Makefile |   3 +
>>   drivers/usb/host/dwc2.c   | 952 ++++++++++++++++++++++++++++++++++++++++++++++
>>   drivers/usb/host/dwc2.h   | 784 ++++++++++++++++++++++++++++++++++++++
>
> In the version Oleksandr sent, there was some header that defined the HW
> registers that had some problematic Synopsis license. Did dwc2.h come
> from the Linux kernel? If that is the case, aren't we supposed to say
> which kernel commit and path it came from?

  parent reply	other threads:[~2014-09-24 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 13:13 [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block Marek Vasut
2014-09-22  9:40   ` Pavel Machek
2014-09-22 10:53     ` Marek Vasut
2014-09-30 11:57       ` Pavel Machek
2014-09-23 21:59   ` Dinh Nguyen
2014-09-26  7:29     ` Marek Vasut
2014-09-26 15:01       ` Dinh Nguyen
2014-09-26 15:59         ` Marek Vasut
2014-09-24  3:31   ` Stephen Warren
2014-09-24  9:25     ` Marek Vasut
2014-09-24 15:37     ` Stephen Warren [this message]
2014-09-24 17:47       ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support Marek Vasut
2014-09-23 19:55   ` Dinh Nguyen
2014-09-23 20:16     ` Marek Vasut
2014-09-23 22:21     ` Dinh Nguyen
2014-09-23 23:36       ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 3/3] arm: rpi: Enable USB support on RPi Marek Vasut
2014-09-29  7:02 ` [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422E52C.9070201@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox