From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dinh Nguyen Date: Fri, 26 Sep 2014 10:01:22 -0500 Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block In-Reply-To: <201409260929.55462.marex@denx.de> References: <1411305204-11731-1-git-send-email-marex@denx.de> <1411305204-11731-2-git-send-email-marex@denx.de> <201409260929.55462.marex@denx.de> Message-ID: <54257FC2.3080501@opensource.altera.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/26/2014 02:29 AM, Marek Vasut wrote: > On Tuesday, September 23, 2014 at 11:59:28 PM, Dinh Nguyen wrote: > > > btw. please try to trim down the content of the patch when replying only to the > relevant part, so others don't have to look up the relevant bits among billions > of lines of irrelevant stuff. > Will do more snipping... > [...] > > >>> +#define DWC2_GUSBCFG_TX_END_DELAY (1 << 28) >>> +#define DWC2_GUSBCFG_TX_END_DELAY_OFFSET 28 >> >> bits 29 and 30 of GUSBCFG are to Force Host and Device mode, respectively. >> These bits may get used in the future. > > That's good, what's their exact name please ? > They should be: #define DWC2_GUSBCFG_FORCEDEVMODE (1 << 30) #define DWC2_GUSBCFG_FORCEHOSTMODE (1 << 29) Also, for patch 1/3 and 2/3, I was able to test USB functionality on the SoCFPGA devkit. So you can add: Tested-by: Dinh Nguyen Thanks, Dinh