[U-Boot] [PATCH V3 1/3] usb: eth: fix Makefile

Marek Vasut
2014-09-26T08:12:58Z

On Friday, September 26, 2014 at 10:08:47 AM, Rene Griessl wrote:
> fix issue as discussed with Marek Vasut

Now I'm twice as famous ;-)

But in fact, you should actually explain the change you did in the commit
message (aka. something along the lines of the ifdef being useless and that
using simpler and consistent notation is fine).

> Signed-off-by: Rene Griessl <rgriessl@cit-ec.uni-bielefeld.de>
> ---
> drivers/usb/eth/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/eth/Makefile b/drivers/usb/eth/Makefile
> index 94551c4..e6ae9f1 100644
> --- a/drivers/usb/eth/Makefile
> +++ b/drivers/usb/eth/Makefile
> @@ -5,8 +5,6 @@
>
> # new USB host ethernet layer dependencies
> obj-$(CONFIG_USB_HOST_ETHER) += usb_ether.o
> -ifdef CONFIG_USB_ETHER_ASIX
> -obj-y += asix.o
> -endif
> +obj-$(CONFIG_USB_ETHER_ASIX) += asix.o
> obj-$(CONFIG_USB_ETHER_MCS7830) += mcs7830.o
> obj-$(CONFIG_USB_ETHER_SMSC95XX) += smsc95xx.o

Best regards,
Marek Vasut