From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Sun, 28 Sep 2014 15:01:19 -0700
Subject: [U-Boot] [PATCH] ci_udc: force full-speed operation if
	!CONFIG_USB_GADGET_DUALSPEED
In-Reply-To: <201409282228.03314.marex@denx.de>
References: <1411931555-15826-1-git-send-email-eric.nelson@boundarydevices.com>
	<201409282228.03314.marex@denx.de>
Message-ID: <5428852F.6030103@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 09/28/2014 01:28 PM, Marek Vasut wrote:
> On Sunday, September 28, 2014 at 09:12:35 PM, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>>  drivers/usb/gadget/ci_udc.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
>> index 2572b34..9f2fd15 100644
>> --- a/drivers/usb/gadget/ci_udc.c
>> +++ b/drivers/usb/gadget/ci_udc.c
>> @@ -777,6 +777,11 @@ static int ci_pullup(struct usb_gadget *gadget, int
>> is_on) /* select DEVICE mode */
>>  		writel(USBMODE_DEVICE, &udc->usbmode);
>>
>> +#if !defined(CONFIG_USB_GADGET_DUALSPEED) && defined(CONFIG_MX6)
>> +		/* force full-speed mode */
>> +		writel(readl(&udc->portsc)|(1<<24), &udc->portsc);
>> +#endif
>> +
> 
> setbits_le32() and I'm sure you know better than to use 1 << 24 . Please define 
> that bit proper.
>
Yep. Will do.

>
> And you also know you should supply a commit message, right ?
> 

I'll give it another shot in V2.

>>  		writel(0xffffffff, &udc->epflush);
>>
>>  		/* Turn on the USB connection by enabling the pullup resistor */
> 

Regards,


Eric