From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] usb: ci_udc: respect CONFIG_USB_GADGET_DUALSPEED
Date: Sun, 28 Sep 2014 18:30:50 -0700 [thread overview]
Message-ID: <5428B64A.2060106@boundarydevices.com> (raw)
In-Reply-To: <20140929012119.GA21079@saruman>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/28/2014 06:21 PM, Felipe Balbi wrote:
> On Sun, Sep 28, 2014 at 05:36:56PM -0700, Eric Nelson wrote:
>> @@ -777,6 +778,11 @@ static int ci_pullup(struct usb_gadget
>> *gadget, int is_on) /* select DEVICE mode */
>> writel(USBMODE_DEVICE, &udc->usbmode);
>>
>> +#if !defined(CONFIG_USB_GADGET_DUALSPEED) &&
>> defined(CONFIG_MX6)
>
> why only MX6 ?
>
This shouldn't be the case. I'll fix in V3.
I also just noticed an extraneous variable declaration.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUKLZJAAoJEFUqXmm9AiVrK9gH/0XPpea8XDasyCtElV3WolzP
C4RaqGrL6iRL2haiuY4zhIHv3KMxg+1L2P6rGrbYFn7+15mNhSMwqkSleRcDL8bw
47j5snivpd0BEnznC+dIzc/vghJ+gpkZdwmnRsfAvfGN+PWV1jNJUSR+jFkzTS6F
19rp2TIoIR9XgFx9chHmluI1iWp39yXTFhgqXLoLLMYMR0qXKTp8TV7asXvWLBsw
+Rrlqf58j3rEmhBA8zNDIbDJe/aQDKbxHcZrK386n2izBK3fZqf4Ew2Pln8vSToU
jHLnEwUp0PoeolUg1EK3oAlitNnwE7GLxxEoxsA/v7KaLzyUoR/c4wpG5/pIu2A=
=Hdj5
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-09-29 1:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 19:12 [U-Boot] [PATCH] ci_udc: force full-speed operation if !CONFIG_USB_GADGET_DUALSPEED Eric Nelson
2014-09-28 20:28 ` Marek Vasut
2014-09-28 22:01 ` Eric Nelson
2014-09-29 0:36 ` [U-Boot] [PATCH V2] usb: ci_udc: respect CONFIG_USB_GADGET_DUALSPEED Eric Nelson
2014-09-29 1:21 ` Felipe Balbi
2014-09-29 1:30 ` Eric Nelson [this message]
2014-09-29 1:35 ` [U-Boot] [PATCH] " Eric Nelson
2014-09-29 14:01 ` Felipe Balbi
2014-09-29 14:43 ` Marek Vasut
2014-09-29 17:04 ` Eric Nelson
2014-09-29 22:59 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5428B64A.2060106@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox