* [U-Boot] drivers/net/phy/icplus.c delete reason
@ 2014-09-30 7:14 Dvorkin Dmitry
2014-09-30 8:25 ` Wolfgang Denk
2014-09-30 8:26 ` Masahiro Yamada
0 siblings, 2 replies; 3+ messages in thread
From: Dvorkin Dmitry @ 2014-09-30 7:14 UTC (permalink / raw)
To: u-boot
Hello Masahiro Yamada!
4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver
for a frequently used and cheap IP101A/G phy. Is there are better
alternative PHY driver in U-Boot for this device? If not, could you
patch it back?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] drivers/net/phy/icplus.c delete reason
2014-09-30 7:14 [U-Boot] drivers/net/phy/icplus.c delete reason Dvorkin Dmitry
@ 2014-09-30 8:25 ` Wolfgang Denk
2014-09-30 8:26 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2014-09-30 8:25 UTC (permalink / raw)
To: u-boot
Dear Dmitry,
In message <542A5861.7010000@tibbo.com> you wrote:
>
> 4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver
> for a frequently used and cheap IP101A/G phy. Is there are better
> alternative PHY driver in U-Boot for this device? If not, could you
> patch it back?
The commit message is pretty explicit about the reason:
commit 368b4d2b49bbbf379d9334747fbbd2aaaafe4356
Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
Date: Mon Aug 4 08:11:37 2014 +0900
drivers: net: remove dead drivers
The following configs are not defined at all:
- CONFIG_INCA_IP_SWITCH
- CONFIG_PBL2800_ETHER
- CONFIG_PHY_ICPLUS
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
There is/was not a single board configuration in mainline U-Boot which
defined CONFIG_PHY_ICPLUS, i. e. the driver was just dead, unused
code.
So the PHY may be "frequently used and cheap", but the driver for it
has never been used in mainline, so we finally got rid of the dead
weight.
I can see no reason to adding it back - this can be easily done if
someone wants to actually use this driver, i. e. for example if you
submit a boad configuration which references it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's when they say 2 + 2 = 5 that I begin to argue." - Eric Pepke
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] drivers/net/phy/icplus.c delete reason
2014-09-30 7:14 [U-Boot] drivers/net/phy/icplus.c delete reason Dvorkin Dmitry
2014-09-30 8:25 ` Wolfgang Denk
@ 2014-09-30 8:26 ` Masahiro Yamada
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2014-09-30 8:26 UTC (permalink / raw)
To: u-boot
Hi Dvorkin,
On Tue, 30 Sep 2014 11:14:41 +0400
Dvorkin Dmitry <dvorkin@tibbo.com> wrote:
> Hello Masahiro Yamada!
>
> 4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver for a frequently used and cheap IP101A/G phy. Is there are better alternative PHY driver in U-Boot for this device? If not, could you patch it back?
I assume you are mentioning commit 368b4d2b49bb (drivers: net: remove dead drivers).
I have no idea if the latest U-Boot code has an alternative PHY driver.
I am not willing to send the patch because I have no interest
in re-adding drivers I am not using.
If necessary for you, please feel free to send a patch to get it back.
(Please make sure there exists at least one board enabling the driver.
This is not my way, but the community's way.)
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-30 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 7:14 [U-Boot] drivers/net/phy/icplus.c delete reason Dvorkin Dmitry
2014-09-30 8:25 ` Wolfgang Denk
2014-09-30 8:26 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox