From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?David_M=c3=bcller_=28ELSOFT_AG=29?= Date: Tue, 30 Sep 2014 16:58:35 +0200 Subject: [U-Boot] [PATCH] PATI: fix broken SPI access In-Reply-To: References: <1412076234-2946-1-git-send-email-d.mueller@elsoft.ch> <542AABF3.7010105@elsoft.ch> Message-ID: <542AC51B.2080407@elsoft.ch> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jagan Teki wrote: > On 30 September 2014 18:41, David M?ller (ELSOFT AG) > wrote: >> Jagan Teki wrote: >>> On 30 September 2014 16:53, David M?ller wrote: >>>> +int board_early_init_f(void) >>>> +{ >>>> + spi_init_f(); >>> >>> Why you need to do this, spi_init_f is trying to call from >>> arch/powerpc/lib/board.c >>> any specific reason, I couldn't understand the fix you mentioned on >>> the commit body. >> >> There is an EEPROM attached to the SPI channel containing vital board >> data. Calling spi_init_f() from arch/powerpc/lib/board.c will be too late. > > Sorry, this looks an other issue - but anyway we're trying to remove What kind of "other issue" do you mean? > spi_init* stuff > from drivers/spi/* in future and I don't think it's a good idea to use that. In this case what is the proposed way of initializing the SPI subsystem?