public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/11] dm: imx: Use gpio_request() to request GPIOs
Date: Wed, 01 Oct 2014 14:58:02 +0300	[thread overview]
Message-ID: <542BEC4A.1030603@compulab.co.il> (raw)
In-Reply-To: <1410966166-20767-9-git-send-email-sjg@chromium.org>

Hi Simon,

On 17/09/14 18:02, Simon Glass wrote:
> GPIOs should be requested before use. Without this, driver model will not
> permit the GPIO to be used.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

This patch introduces a bunch of errors (once the driver model stuff is
turned on), all related to the gpios never being freed, but requested
anew when reinitializing subsystems.

The errors are:

CM-FX6 # sata init
Warning: iSSD setup failed!
AHCI 0001.0300 32 slots 1 ports 3 Gbps 0x1 impl SATA mode
flags: ncq stag pm led clo only pmp pio slum part
SATA Device Info:
S/N: 123900127157
Product model number: SanDisk SSD i100 8GB
Firmware version: 11.56.00
Capacity: 15649200 sectors

CM-FX6 # usb start
(Re)start USB...
USB0:   USB OTG pwr gpio request failed: -16
USB OTG pwr gpio request failed: -16
USB EHCI 1.00
scanning bus 0 for devices... 2 USB Device(s) found
USB1:   USB hub rst gpio request failed: -16
USB hub rst gpio request failed: -16
USB EHCI 1.00
scanning bus 1 for devices... 6 USB Device(s) found
        scanning usb for storage devices... max USB Storage Device 
reached: 5 stopping
5 Storage Device(s) found

CM-FX6 # sf probe
mxc_spi: cannot setup gpio -16
SF: Failed to set up slave
Failed to initialize SPI flash at 0:0

CM-FX6 # saveenv
Saving Environment to SPI Flash...
mxc_spi: cannot setup gpio -16
SF: Failed to set up slave
*** Warning - spi_flash_probe() failed, using default environment

I am going to submit a modified version of the cm_fx6 patches to address
these problems.

-- 
Regards,
Nikita Kiryanov

  parent reply	other threads:[~2014-10-01 11:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 15:02 [U-Boot] [PATCH v3 0/11] dm: imx: Add driver model support for GPIO and serial on cm_fx6 Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 01/11] dm: linker_lists: Add a way to declare multiple objects Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 02/11] dm: core: Allow a list of devices to be declared in one step Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 03/11] dm: core: Allow device_bind() to used without CONFIG_OF_CONTROL Simon Glass
2014-09-26 18:59   ` Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 04/11] initcall: Display error number when an error occurs Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 05/11] dm: serial: Don't require device tree to configure a console Simon Glass
2014-09-26 19:00   ` Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 06/11] dm: serial: Put common code into separate functions Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 07/11] imx: Add error checking to setup_i2c() Simon Glass
2014-09-18  7:27   ` Igor Grinberg
2014-10-01  7:26   ` Stefano Babic
2014-10-01 11:31   ` Nikita Kiryanov
2014-10-01 15:25     ` Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 08/11] dm: imx: Use gpio_request() to request GPIOs Simon Glass
2014-09-18  7:33   ` Igor Grinberg
2014-10-01  7:28   ` Stefano Babic
2014-10-01 11:58   ` Nikita Kiryanov [this message]
2014-10-01 15:22     ` Simon Glass
2014-10-02 10:28       ` Nikita Kiryanov
2014-10-02 16:02         ` Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 09/11] dm: imx: gpio: Support driver model in MXC gpio driver Simon Glass
2014-09-18  7:35   ` Igor Grinberg
2014-09-18 13:49     ` Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 10/11] dm: imx: serial: Support driver model in the MXC serial driver Simon Glass
2014-09-17 15:02 ` [U-Boot] [PATCH v3 11/11] dm: imx: Move cm_fx6 to use driver model for serial and GPIO Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542BEC4A.1030603@compulab.co.il \
    --to=nikita@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox