From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 01 Oct 2014 21:25:12 +0200 Subject: [U-Boot] [RFC PATCH 4/4 v3] mtd: sf: Add CONFIG_SPI_N25Q256A_RESET for software-reset In-Reply-To: References: <1412176391-24475-1-git-send-email-sr@denx.de> <1412176391-24475-5-git-send-email-sr@denx.de> <201410012025.55937.marex@denx.de> <542C4E8B.7000807@denx.de> Message-ID: <542C5518.7090801@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01.10.2014 21:04, Jagan Teki wrote: >>>> This is needed for the SoCFPGA booting from SPI NOR flash >>>> e.g. (N25Q256A). With these changes, the SoCrates can boot and >>>> re-boot (reset) from SPI NOR flash without any problems. >>> >>> >>> Seems like your SPI NOR reset logic is buggy. Does any of [1] apply to >>> your >>> board please? >>> >>> [1] http://www.rocketboards.org/foswiki/Documentation/SocBoardQspiBoot >> >> >> Yes. This seems to be that case. But I can't change it right now. So this >> "solution" with the soft-reset is better than nothing. > > If this is some think that must require, any possibility to this > resetting prior to u-boot? > like preloader or in first stage boot loader or something. Perhaps I was not clear with the intention of this patch. Its more to show how the problem with SPI flash on this platform / board (SoCrates in this case) can be solved. So that others have a reference. Thats why I marked it as RFC. Its not really meant for inclusion into mainline. The real solution is a board rework. If not possible, the preloader should be changed. As I don't have access to the preloader code right now, this "solution" (I know, its more a hack) didn't seem too bad. > I feel this is mostly a kind of hardware treat, and looks like it's > touching generic sf framework > which is not so good. Full ack on this. So please don't pull in into mainline. Thanks, Stefan