From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Rae Date: Wed, 1 Oct 2014 13:39:43 -0700 Subject: [U-Boot] [PATCH 2/3] usb: gadget: fastboot: explicitly set radix of maximum download size In-Reply-To: <1412103942-28331-3-git-send-email-eric.nelson@boundarydevices.com> References: <1412103942-28331-1-git-send-email-eric.nelson@boundarydevices.com> <1412103942-28331-3-git-send-email-eric.nelson@boundarydevices.com> Message-ID: <542C668F.1070204@broadcom.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14-09-30 12:05 PM, Eric Nelson wrote: > The processing of the max-download-size variable requires a > radix specifier, or the fastboot host tool will interpret > it as an octal number. > > See function get_target_sparse_limit() in file fastboot/fastboot.c > in the AOSP: > https://android.googlesource.com/platform/system/core/+/master > > Signed-off-by: Eric Nelson > --- > drivers/usb/gadget/f_fastboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c > index f970f89..86700f5 100644 > --- a/drivers/usb/gadget/f_fastboot.c > +++ b/drivers/usb/gadget/f_fastboot.c > @@ -355,7 +355,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) > !strcmp_l1("max-download-size", cmd)) { > char str_num[12]; > > - sprintf(str_num, "%08x", CONFIG_USB_FASTBOOT_BUF_SIZE); > + sprintf(str_num, "0x%08x", CONFIG_USB_FASTBOOT_BUF_SIZE); > strncat(response, str_num, chars_left); > } else if (!strcmp_l1("serialno", cmd)) { > s = getenv("serial#"); > (the host version of fastboot that I'm using requires this change!) Tested-by: Steve Rae