From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 06 Oct 2014 10:37:50 +0200
Subject: [U-Boot] [PATCH 6/6] sunxi: Enable second sdcard slot found on
 some boards
In-Reply-To: <1412411965.17796.63.camel@hellion.org.uk>
References: <1412348759-4599-1-git-send-email-hdegoede@redhat.com>	
	<1412348759-4599-7-git-send-email-hdegoede@redhat.com>	
	<1412411895.17796.62.camel@hellion.org.uk>
	<1412411965.17796.63.camel@hellion.org.uk>
Message-ID: <543254DE.2020103@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 10/04/2014 10:39 AM, Ian Campbell wrote:
> On Sat, 2014-10-04 at 09:38 +0100, Ian Campbell wrote:
>> On Fri, 2014-10-03 at 17:05 +0200, Hans de Goede wrote:
>>> diff --git a/configs/Mele_M3_defconfig b/configs/Mele_M3_defconfig
>>> index 645b236..50979e2 100644
>>> --- a/configs/Mele_M3_defconfig
>>> +++ b/configs/Mele_M3_defconfig
>>> @@ -1,5 +1,7 @@
>>>  CONFIG_SPL=y
>>>  CONFIG_SYS_EXTRA_OPTIONS="MELE_M3,AXP209_POWER,SUNXI_GMAC,USB_EHCI"
>>>  CONFIG_FDTFILE="sun7i-a20-m3.dtb"
>>> ++S:CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>>
>> This one is +S (regular+SPL) while the other two are just S (regular
>> only). Is that deliberate?
> 
> Sorry, I should have read the commit message more carefully as you
> explained it quite clearly there!
> 
> This patch looks good, except insofar as some of my comments on earlier
> patches could result in it looking completely different, sorry about
> that!

Heh, no worries. I'll try to do a v2 today addressing all your concerns.

Regards,

Hans